-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding libvirt provider to helper interactive script for setting peer-pods-cm #501
Adding libvirt provider to helper interactive script for setting peer-pods-cm #501
Conversation
Hi @Saripalli-lavanya. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
e3163cb
to
91c9d78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @Saripalli-lavanya
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM overall, just notice libvirt_optional is not set, IDK if it's on purpose..
Thank you for the review @snir911, we have set libvirt_optional as LIBVIRT_IMAGE_ID" |
Currently helper script has only support for AWS and Azure extending it to Libvirt as well. Signed-off-by: Saripalli Lavanya <[email protected]>
91c9d78
to
481c463
Compare
New changes are detected. LGTM label has been removed. |
/retest |
@Saripalli-lavanya: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be good to merge.
Will wait for some time if anyone has any other comments.
Currently helper script has only support for AWS and Azure extending it to Libvirt as well.