Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding libvirt provider to helper interactive script for setting peer-pods-cm #501

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

Saripalli-lavanya
Copy link
Contributor

Currently helper script has only support for AWS and Azure extending it to Libvirt as well.

[root@bastion-sl ~]# ./cm-helper.sh ch
##### OSC ConfigMap Configurator #####
Cluster infrastructure is libvirt
Env file: /tmp/pp-cm-env-HDIJ.env
Provider is libvirt, skipping getIMDSDefaults.

###### Setting Values (press Enter for the [suggested] value, "drop" to remove key)
CLOUD_PROVIDER [libvirt]: 
VXLAN_PORT [9000]: 
PROXY_TIMEOUT [5m]: 
DISABLECVM [true]: 
LIBVIRT_POOL [default]: sl-testing
LIBVIRT_VOL_NAME [default]: sl-testing
LIBVIRT_DIR_NAME [default]: /var/lib/libvirt/images/
Cloud Provider is libvirt

###### Applying
Apply the Changes to the peer-pods-cm ConfigMap? [y/N] y
configmap/peer-pods-cm created
{
  "CLOUD_PROVIDER": "libvirt",
  "DISABLECVM": "true",
  "LIBVIRT_DIR_NAME": "/var/lib/libvirt/images/",
  "LIBVIRT_POOL": "sl-testing",
  "LIBVIRT_VOL_NAME": "sl-testing",
  "PROXY_TIMEOUT": "5m",
  "VXLAN_PORT": "9000"
}
Restart DaemonSet so that CM will be taken into account? [y/N] N
[root@bastion-sl ~]# 

@openshift-ci openshift-ci bot requested review from gkurz and littlejawa January 22, 2025 13:02
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 22, 2025
Copy link

openshift-ci bot commented Jan 22, 2025

Hi @Saripalli-lavanya. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Saripalli-lavanya Saripalli-lavanya force-pushed the sl-libvirt-cm-helper branch 2 times, most recently from e3163cb to 91c9d78 Compare January 30, 2025 14:24
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @Saripalli-lavanya

@bpradipt bpradipt requested a review from snir911 February 5, 2025 11:02
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2025
@bpradipt bpradipt added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 5, 2025
Copy link
Contributor

@snir911 snir911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM overall, just notice libvirt_optional is not set, IDK if it's on purpose..

scripts/cm-helpers/pp-cm-helper.sh Show resolved Hide resolved
@Saripalli-lavanya
Copy link
Contributor Author

Thanks, LGTM overall, just notice libvirt_optional is not set, IDK if it's on purpose..

Thank you for the review @snir911, we have set libvirt_optional as LIBVIRT_IMAGE_ID"

Currently helper script has only support for AWS and Azure extending it to Libvirt as well.

Signed-off-by: Saripalli Lavanya <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2025
Copy link

openshift-ci bot commented Feb 5, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 5, 2025
@Saripalli-lavanya
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented Feb 11, 2025

@Saripalli-lavanya: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good to merge.
Will wait for some time if anyone has any other comments.

@bpradipt bpradipt merged commit fe1da90 into openshift:devel Feb 12, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants