Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot deletion validation during KataConfig removal #515

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

gsid100
Copy link

@gsid100 gsid100 commented Jan 28, 2025

During KataConfig (with peer pods enabled) deletion, we delete the AMI and the snapshot associated with the podvm image. In this PR I Included a validation for ensuring the Snapshot associated with the AMI was deleted properly

- Description of the problem which is fixed/What is the use case
Lack of validation to ensure the snapshot was deleted

- What I did
Added validations to the 'aws-podvm-image-handler.sh' script

- How to verify it

  • Create KataConfig
  • Save the Snapshot ID associated with the AMI (by running aws cli commands)
  • Delete KataConfig
  • Examine the logs of the podvm delete pod and verify it shows "Snapshot '${SNAPSHOT_ID}' successfully deleted"

- Description for the changelog
Validating aws ami snapshot is deleted properly during KataConfig removal

@openshift-ci openshift-ci bot requested review from snir911 and vvoronko January 28, 2025 13:26
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 28, 2025
Copy link

openshift-ci bot commented Jan 28, 2025

Hi @gsid100. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Included a validation for ensuring the Snapshot associated with the AMI was deleted properly

Signed-off-by: Gilad Sid <[email protected]>
@gsid100 gsid100 force-pushed the validate-aws-snapshot-deletion branch from 1119f2d to 47eac9e Compare January 28, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant