Podvm builder dockerfile #517
Conversation
Creating a new Dockerfile dedicated to building the podvm-builder image in Konflux. It seems we can't use the existing Dockerfile as it is, because of the subscription management done in Konflux. (see PR openshift#516) This Dockerfile is a clean copy of Dockerfile.podvm-builder, with the subscription lines removed. Signed-off-by: Julien Ropé <[email protected]>
For the Openshift-dedicated Dockerfile, make the source references point to the forks under the Openshift org. Signed-off-by: Julien Ropé <[email protected]>
|
@spotlesstofu - I'd like your comments on this one, and/or on the #516 one. At the moment, my vote is to go with the duplicated Dockerfile, and if/when we find a better way, fix it to keep a single one. But any suggestion is welcome :-) |
|
@littlejawa: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Thanks @littlejawa , have you tried to comment this line out? if it's still identified by kuflux also as a comment I'd simply remove the line completely and add a comment mentioning "for unsubscribe systems subscribe using subscription manager as the first build step" or something like that |
|
Yes, commenting it is enough. |
|
I'd leave it commented out, it's useful when you build on unsubscribed system |
|
I have re-opened #516 and commented the lines in the Dockerfile. It builds now. |
|
|
||
| RUN mkdir -p /scripts | ||
|
|
||
| ADD lib.sh libvirt-podvm-image-handler.sh aws-podvm-image-handler.sh azure-podvm-image-handler.sh /scripts/ |
There was a problem hiding this comment.
Probably this will conflict with #519 but I can handle on my side. Just adding a note so we (I) don't forget :)
|
|
||
| ARG ORG_ID | ||
| ARG ACTIVATION_KEY | ||
|
|
There was a problem hiding this comment.
About the subscription code that was here... I'm not familiar on how konflux handles this (maybe @spotlesstofu).
But, I was wondering if something like this would work:
RUN if [[ -z "${KONFLUX_BUILD}" ]]; then \
rm -f /etc/rhsm-host && rm -f /etc/pki/entitlement-host; \
subscription-manager register --org=${ORG_ID} --activationkey=${ACTIVATION_KEY}; \
fi
Not sure if the konflux already exposes any variable, but if not, maybe we can configure those variables within the tekton folder. This way we could avoid having two dockerfiles. Wdyt?
|
Dropping in favor of #516 |
Creating a new Dockerfile dedicated to building the podvm-builder image in Konflux.
It seems we can't use the existing Dockerfile as it is, because of the subscription
management done in Konflux.
(see PR #516)
This Dockerfile is a clean copy of Dockerfile.podvm-builder, with the subscription
lines removed.
Also updating the source references to kata and cloud-api-adaptor to point to our forks under the Openshift org.