Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nested SNAT in uni-eta #479

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

renjingxiao
Copy link
Contributor

Copy link

openshift-ci bot commented Jan 23, 2025

Hi @renjingxiao. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@abays abays marked this pull request as draft January 23, 2025 18:01
@renjingxiao renjingxiao force-pushed the test_nested_snat branch 3 times, most recently from 543ebd1 to 99a7617 Compare February 5, 2025 12:34
@renjingxiao renjingxiao marked this pull request as ready for review March 13, 2025 09:58
@openshift-ci openshift-ci bot requested a review from cjeanner March 13, 2025 09:58
@renjingxiao renjingxiao changed the title [Draft] set ovn_router_indirect_snat = true Enable nested SNAT in uni-eta Mar 13, 2025
@sdatko
Copy link
Contributor

sdatko commented Mar 13, 2025

/ok-to-test

Copy link

openshift-ci bot commented Mar 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: renjingxiao, sdatko
Once this PR has been reviewed and has the lgtm label, please assign raukadah for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdatko sdatko force-pushed the test_nested_snat branch from 99a7617 to e8d52e0 Compare March 13, 2025 15:23
@openshift-ci openshift-ci bot removed the lgtm label Mar 13, 2025
Copy link

openshift-ci bot commented Mar 13, 2025

New changes are detected. LGTM label has been removed.

@sdatko sdatko merged commit 357593f into openstack-k8s-operators:main Mar 13, 2025
6 checks passed
@sdatko
Copy link
Contributor

sdatko commented Mar 14, 2025

/cherry-pick 18.0-fr2

@openshift-cherrypick-robot

@sdatko: new pull request created: #520

In response to this:

/cherry-pick 18.0-fr2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants