Switch cinder uniquePodNames to true for DCN deployments #481
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fmount The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Do we want to set it explicitly to true, or remove it completely, thus relying on its default value and fully reverting #436 ? |
fmount
force-pushed
the
unique_pm
branch
2 times, most recently
from
512fde1 to
c873f30
Compare
Hi @tosky, I'm ok to revert #436 entirely. I added a couple of minor changes in the way we resolve the |
This patch reverts the work done in [1], where uniquePodNames was added as a kustomization parameter for cinder and switched to false due to [2]. In addition, this patch fixes the way extraMounts Ceph secrets are accessed, and removes the not required "projected" key. [1] openstack-k8s-operators#436 [2] https://issues.redhat.com/browse/OSPRH-11240 Signed-off-by: Francesco Pantano <[email protected]>
Done |
|
Looks fine to me. Waiting for test results before merging. |
This patch reverts the work done in [1], where
uniquePodNameswas added as a
kustomizationparameter for Cinder and switchedto false due to [2].
In addition, this patch fixes the way
extraMountsCephsecretsare accessed, and removes the not required
projectedkey.[1] #436
[2] https://issues.redhat.com/browse/OSPRH-11240
Jira: https://issues.redhat.com/browse/OSPRH-11240