Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom ovn_emit_need_to_frag config #483

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renjingxiao
Copy link

custom ovn_emit_need_to_frag config is not needed in job overrides.

Related issue: https://issues.redhat.com/browse/OSPRH-10684

@openshift-ci openshift-ci bot requested review from fultonj and raukadah January 28, 2025 15:17
Copy link

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: renjingxiao
Once this PR has been reviewed and has the lgtm label, please assign cjeanner for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jan 28, 2025

Hi @renjingxiao. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@renjingxiao renjingxiao marked this pull request as draft January 29, 2025 16:04
@renjingxiao renjingxiao changed the title [Draft] remove custom ovn_emit_need_to_frag config Remove custom ovn_emit_need_to_frag config Feb 4, 2025
@renjingxiao renjingxiao marked this pull request as ready for review February 4, 2025 09:33
@openshift-ci openshift-ci bot requested review from abays and karelyatin February 4, 2025 09:33
@renjingxiao renjingxiao marked this pull request as draft February 4, 2025 09:44
@abays
Copy link
Contributor

abays commented Feb 4, 2025

/ok-to-test

@abays
Copy link
Contributor

abays commented Feb 5, 2025

@karelyatin Would you mind providing your thoughts on this?

@karelyatin
Copy link
Contributor

@karelyatin Would you mind providing your thoughts on this?

@abays change in itself is fine, but i think we should wait until neutron-operator change get's shipped, /me not sure if any jobs running with released operators. The neutron-operator change merged in 18.0-fr1 and available in downstream trunk operators but not in non-trunk yet.

@renjingxiao renjingxiao marked this pull request as ready for review February 6, 2025 09:06
@renjingxiao renjingxiao marked this pull request as draft February 6, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants