-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple uni01alpha network stage from control plane stage #497
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hjensas The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0830e0c56dda42e887f585b7c16b5090 ✔️ noop SUCCESS in 0s |
f1917c1
to
9c3b7e5
Compare
I ran a testproject, the controlplane and EDPM networker nodes deployed fine, EDPM computes failed on an unrelated authentication error when attempting to pulling containers from registry.redhat.io. A grep in the
|
Tested with regular unialpha job. Deployment passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems not related to dt/uni01alpha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
w00t, indeed this patch should not change those files.
Thanks for catching that @dsariel, I am not sure what went wrong there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
va/hci files reverted to what is on main.
DONE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
va/hci files reverted to what is on main.
DONE
This removes the networking components... MetalLB NetConfig Net-attach-def ...from the control plane stage of dt/uni01alpha and gives them their own separate stage in between the NNCP stage and the control plane stage. This is needed for the uni01alpha adoption job, which relies upon this DT. For adoption we want to create the NNCPs, MetalLB CRs, NetConfig CR and Net-attach-defs, but do NOT want to create the OpenStackControlPlane. Following this can this can be done by creating an automation file with only two stages, one for NNCPs and the other for the other networking components. This change was created using the following PR as inspiration: openstack-k8s-operators#489 Jira: OSPRH-13801
This removes the networking components...
...from the control plane stage of dt/uni01alpha and gives them their own separate stage in between the NNCP stage and the control plane stage.
This is needed for the uni01alpha adoption job, which relies upon this DT. For adoption we want to create the NNCPs, MetalLB CRs, NetConfig CR and Net-attach-defs, but do NOT want to create the OpenStackControlPlane.
Following this can this can be done by creating an automation file with only two stages, one for NNCPs and the other for the other networking components.
This change was created using the following PR as inspiration: #489
Jira: OSPRH-13801