Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for cifmw_repo_setup_component_name definition #1670

Merged
merged 1 commit into from
May 10, 2024
Merged

Check for cifmw_repo_setup_component_name definition #1670

merged 1 commit into from
May 10, 2024

Conversation

rlandy
Copy link
Collaborator

@rlandy rlandy commented May 9, 2024 •
edited
Loading

DLRN promote jobs in integration lines are failing this check as cifmw_repo_setup_component_name
is not defined. Add a check for the var definition before checking length.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

@rlandy
Check for cifmw_repo_setup_component_name definition
5b6208d 
DLRN promote jobs in integration lines are failing
this check as cifmw_repo_setup_component_name
is not defined. Add a check for the var definition
before checking length.
@openshift-ci openshift-ci bot requested review from dasm and lewisdenny May 9, 2024 19:08
@github-actions github-actions bot marked this pull request as draft May 9, 2024 19:08
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Thanks for the PR! ❤️
I am marking it as a draft, once passing your happy and the PR is passing CI click the "Ready for review" button below.

@rlandy
Copy link
Collaborator Author

rlandy commented May 9, 2024

recheck

@rlandy
Copy link
Collaborator Author

rlandy commented May 9, 2024

testing here: https://review.rdoproject.org/r/c/testproject/+/53185

@rlandy
Copy link
Collaborator Author

rlandy commented May 9, 2024

recheck

@rlandy rlandy marked this pull request as ready for review May 9, 2024 19:10
@openshift-ci openshift-ci bot requested review from afazekas and frenzyfriday May 9, 2024 19:10
raukadah
raukadah approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@raukadah raukadah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the lgtm label May 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 57c5d52 into main May 10, 2024
7 of 8 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the cifmw_repo_setup_component_name branch May 10, 2024 05:08
@lewisdenny lewisdenny removed their request for review May 13, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raukadah raukadah raukadah approved these changes

@dasm dasm Awaiting requested review from dasm

@afazekas afazekas Awaiting requested review from afazekas

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday frenzyfriday is a code owner

Assignees

@raukadah raukadah

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rlandy @raukadah