Fix Save repo-setup hash content task #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! ❤️ |
|
/approve |
pablintino
reviewed
May 10, 2024
roles/repo_setup/tasks/artifacts.yml
Outdated
| @@ -24,14 +24,14 @@ | |||
| _repo_setup_json: "{{ _get_hash.stdout | from_json }}" | |||
| block: | |||
| - name: Dump full hash in delorean.repo.md5 file | |||
| when: cifmw_repo_setup_component_promotion_tag is not defined | |||
| when: cifmw_repo_setup_component_name | length <= 0 | |||
There was a problem hiding this comment.
nit: Length of a list returning a negative value?
`Save repo-setup hash content` task dumps the proper dlrn md5 hash for component/intergration/check pipeline. Currently this task depends on cifmw_repo_setup_component_promotion_tag whose default value is defined in role defaults. In this case, this task is working wrongly. Let's use cifmw_repo_setup_component_name length as a param to dump the proper hash. Signed-off-by: Chandan Kumar <[email protected]>
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arxcruz, pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
marios
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save repo-setup hash contenttask dumps the proper dlrn md5 hash for component/intergration/check pipeline.Currently this task depends on cifmw_repo_setup_component_promotion_tag whose default value is defined in role defaults.
In this case, this task is working wrongly. Let's use cifmw_repo_setup_component_name length as a param to dump the proper hash.
As a pull request owner and reviewers, I checked that: