Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libvirt_manager - enable sushy_emulator #1679

Closed
wants to merge 2 commits into from
Closed

libvirt_manager - enable sushy_emulator #1679

wants to merge 2 commits into from

Conversation

hjensas
Copy link
Contributor

@hjensas hjensas commented May 10, 2024 •
edited
Loading

Add a new boolean option:
cifmw_libvirt_manager_enable_sushy_emulator (defaults to: false).

When enabled - include the sushy_emulator role in deploy_layout.yml to set-up virtual RedFish BMC.

Also:

  • Change hos sushy_emulator role builds the libvirt_uri, instead of a lookup from hostvars require the hostname to be defined in a variable when calling the role. This allows use of the role even if the libvirt hypervisor is not managed by ansible.
  • Create a firewall rule to allow traffic to the sushy-emulator port when installed as a podman container.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

@hjensas
libvirt_manager - enable sushy_emulator
1721c1a 
Add a new boolean option:
 `cifmw_libvirt_manager_enable_sushy_emulator` (defaults to: false).

When enabled - include the sushy_emulator role in deploy_layout.yml
to set-up virtual RedFish BMC.

Also change hos sushy_emulator role builds the libvirt_uri, instead
of a lookup from hostvars require the hostname to be defined in
a variable when calling the role. This allows use of the role even
if the libvirt hypervisor is not managed by ansible.
@openshift-ci openshift-ci bot requested review from katarimanojk and pojadhav May 10, 2024 19:03
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign pablintino for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I am marking it as a draft, once passing your happy and the PR is passing CI click the "Ready for review" button below.

@github-actions github-actions bot marked this pull request as draft May 10, 2024 19:03
@hjensas
Create firewall rule to allow sushy-emulator
1d10acb 
If sushy-emulator is installed as `podman` container,
create firewall rule to allow traffic to the sushy-emulator
port.
@hjensas hjensas requested a review from lewisdenny May 10, 2024 19:42
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/635fea83a9ae4386af1774b151c54799

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 37m 19s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 41s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 18m 43s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 52s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 36s
✔️ cifmw-baremetal-nested-crc SUCCESS in 1h 18m 07s
✔️ cifmw-molecule-libvirt_manager SUCCESS in 15m 36s
✔️ cifmw-molecule-reproducer SUCCESS in 15m 27s
❌ cifmw-molecule-sushy_emulator FAILURE in 13m 48s

@hjensas
Copy link
Contributor Author

hjensas commented May 12, 2024

I see there is already a patch to do this : #1560

@hjensas hjensas closed this May 12, 2024
@hjensas hjensas deleted the enable-sushy-emulator branch May 12, 2024 09:39
@hjensas hjensas restored the enable-sushy-emulator branch May 12, 2024 09:40
@hjensas hjensas deleted the enable-sushy-emulator branch July 3, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katarimanojk katarimanojk Awaiting requested review from katarimanojk

@pojadhav pojadhav Awaiting requested review from pojadhav

@lewisdenny lewisdenny Awaiting requested review from lewisdenny lewisdenny is a code owner

@pablintino pablintino Awaiting requested review from pablintino pablintino will be requested when the pull request is marked ready for review pablintino is a code owner

@evallesp evallesp Awaiting requested review from evallesp evallesp will be requested when the pull request is marked ready for review evallesp is a code owner

@bshewale bshewale Awaiting requested review from bshewale bshewale will be requested when the pull request is marked ready for review bshewale is a code owner

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday frenzyfriday will be requested when the pull request is marked ready for review frenzyfriday is a code owner

Assignees
No one assigned
Labels
do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hjensas