Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload crc NetworkManager in reproducer #1682

Merged
merged 1 commit into from
May 15, 2024

Conversation

cescgina
Copy link
Contributor

@cescgina cescgina commented May 13, 2024

The fix for reproducer dns[1] does not seem to work in all instances.
NetworkManager was still overwriting the /etc/resolv.conf contents, so
this change reloads the service after changing the config to ensure it
does not modify the resolv.conf on reboot.

[1] #1637
As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running

Copy link
Contributor

openshift-ci bot commented May 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@cescgina cescgina force-pushed the check_dns_reproducer_change branch from 7e72d8e to b2b234e Compare May 13, 2024 16:15
@cescgina cescgina changed the title [DNM] Add debbuging prints for reproducer dns Reload crc NetworkManager in reproducer May 13, 2024
@cescgina cescgina marked this pull request as ready for review May 13, 2024 16:16
@openshift-ci openshift-ci bot requested review from dasm and psathyan May 13, 2024 16:16
@cescgina cescgina force-pushed the check_dns_reproducer_change branch from b2b234e to 3d97eb0 Compare May 13, 2024 17:21
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/95c7e2580aaa4e8e907cdc7a71a14f6a

✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 40s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 16s
✔️ cifmw-molecule-libvirt_manager SUCCESS in 15m 48s
cifmw-molecule-reproducer FAILURE in 18m 26s

@cescgina
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ef1e111cbb94458e883d6911b5f856e0

✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 50s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 34s
✔️ cifmw-molecule-libvirt_manager SUCCESS in 15m 35s
cifmw-molecule-reproducer FAILURE in 18m 36s

@cescgina cescgina force-pushed the check_dns_reproducer_change branch from 3d97eb0 to e56ce29 Compare May 14, 2024 07:25
The fix for reproducer dns[1] does not seem to work in all instances.
NetworkManager was still overwriting the /etc/resolv.conf contents, so
this change reloads the service after changing the config to ensure it
does not modify the resolv.conf on reboot.

[1] #1637
Copy link
Collaborator

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@raukadah
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ea9dcda into main May 15, 2024
5 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the check_dns_reproducer_change branch May 15, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants