-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reload crc NetworkManager in reproducer #1682
Conversation
Skipping CI for Draft Pull Request. |
7e72d8e
to
b2b234e
Compare
b2b234e
to
3d97eb0
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/95c7e2580aaa4e8e907cdc7a71a14f6a ✔️ noop SUCCESS in 0s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/ef1e111cbb94458e883d6911b5f856e0 ✔️ noop SUCCESS in 0s |
3d97eb0
to
e56ce29
Compare
The fix for reproducer dns[1] does not seem to work in all instances. NetworkManager was still overwriting the /etc/resolv.conf contents, so this change reloads the service after changing the config to ensure it does not modify the resolv.conf on reboot. [1] #1637
e56ce29
to
a64515d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raukadah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The fix for reproducer dns[1] does not seem to work in all instances.
NetworkManager was still overwriting the /etc/resolv.conf contents, so
this change reloads the service after changing the config to ensure it
does not modify the resolv.conf on reboot.
[1] #1637
As a pull request owner and reviewers, I checked that: