Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ansible.builtin.stat to check src file existence #1685

Merged

Conversation

cjeanner
Copy link
Contributor

ansible.builtin.exists is a local test only, and therefore doesn't
work against remote files.

This change modify the way we check for source values.yaml availability,
allowing to run against a remote host (mostly for coming testing)

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running

@openshift-ci openshift-ci bot requested review from dasm and katarimanojk May 13, 2024 17:48
@github-actions github-actions bot marked this pull request as draft May 13, 2024 17:48
Copy link

Thanks for the PR! ❤️
I am marking it as a draft, once passing your happy and the PR is passing CI click the "Ready for review" button below.

@cjeanner cjeanner force-pushed the ci_gen_kustomieze_values/ensure-src-exists branch from 09b3a10 to 4bb62ff Compare May 13, 2024 19:17
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/766984a7967c48abaad458e05c34a13d

openstack-k8s-operators-content-provider MERGE_CONFLICT in 6s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
cifmw-pod-ansible-test MERGE_CONFLICT in 0s
cifmw-pod-pre-commit MERGE_CONFLICT in 0s
cifmw-molecule-ci_gen_kustomize_values MERGE_CONFLICT in 1s

`ansible.builtin.exists` is a local test only, and therefore doesn't
work against remote files.

This change modify the way we check for source values.yaml availability,
allowing to run against a remote host (mostly for coming testing)
@cjeanner cjeanner force-pushed the ci_gen_kustomieze_values/ensure-src-exists branch from 4bb62ff to 89d1532 Compare May 14, 2024 05:34
@cjeanner cjeanner marked this pull request as ready for review May 14, 2024 07:23
@openshift-ci openshift-ci bot requested review from arxcruz and rachael-george May 14, 2024 07:23
@rebtoor
Copy link
Contributor

rebtoor commented May 14, 2024

/approve

Copy link
Contributor

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 616eeef into main May 14, 2024
7 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the ci_gen_kustomieze_values/ensure-src-exists branch May 14, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants