Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci_gen_kustomize] Do ctlplane assertion only if hosts are present #1691

Closed

Conversation

pablintino
Copy link
Collaborator

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

@openshift-ci openshift-ci bot requested review from afazekas and rachael-george May 14, 2024 12:37
Copy link

Thanks for the PR! ❤️
I am marking it as a draft, once passing your happy and the PR is passing CI click the "Ready for review" button below.

@github-actions github-actions bot marked this pull request as draft May 14, 2024 12:37
@lewisdenny lewisdenny self-assigned this May 15, 2024
Copy link
Contributor

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lewisdenny. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lewisdenny lewisdenny force-pushed the ci_gen_kustomize/assert-ctlplane-iface-if-hosts-present branch from 0e6169c to cf9aacd Compare May 15, 2024 05:44
@lewisdenny
Copy link
Collaborator

@pablintino We can close this one if you're happy going with #1706

@pablintino
Copy link
Collaborator Author

Entirely replaced by #1719
Now the user should kustomize ctlplaneInterface like any other variable.

@pablintino pablintino closed this May 16, 2024
@pablintino pablintino deleted the ci_gen_kustomize/assert-ctlplane-iface-if-hosts-present branch February 4, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants