Refine a bit dnsmasq role #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! ❤️ |
cjeanner
force-pushed
the
dnsmasq/refining
branch
2 times, most recently
from
f76d66a to
ed4233d
Compare
An assertion block was missing a condition, leading to issue when we wanted to just remove a network from the configuration. In the network configuration template, the test to know more about ipv4 and ipv6 ranges was a bit too loose, leading to issues under certain conditions. We faced the same issue in the host management, leading to potentially wrong DHCP configuration. In order to ease debugging, we now generate a fact, display its content, and use that content to inject the host data in the configuration. During a re-run, the service is already stopped/disabled, and the unit file is removed. Ansible will then fail, since systemd can't find the service to stop.
cjeanner
force-pushed
the
dnsmasq/refining
branch
from
ed4233d to
3116f53
Compare
cjeanner
requested review from
rebtoor and
hjensas
and removed request for
dsariel
rebtoor
approved these changes
May 15, 2024
hjensas
approved these changes
May 15, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebtoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An assertion block was missing a condition, leading to issue when we
wanted to just remove a network from the configuration.
In the network configuration template, the test to know more about ipv4
and ipv6 ranges was a bit too loose, leading to issues under certain
conditions.
We faced the same issue in the host management, leading to potentially
wrong DHCP configuration. In order to ease debugging, we now generate a
fact, display its content, and use that content to inject the host data
in the configuration.
During a re-run, the service is already stopped/disabled, and the unit
file is removed. Ansible will then fail, since systemd can't find the
service to stop.
As a pull request owner and reviewers, I checked that: