Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from kustomize to oc kustomize #1703

Merged

Conversation

rebtoor
Copy link
Contributor

@rebtoor rebtoor commented May 15, 2024

We are restoring the "original" behavior but using oc instead of kubectl since it should be available everywhere.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running

Copy link
Contributor

openshift-ci bot commented May 15, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rebtoor rebtoor force-pushed the kubectl_kustomize branch 4 times, most recently from d77747f to 19c2117 Compare May 15, 2024 09:45
@rebtoor rebtoor requested a review from cjeanner May 15, 2024 10:01
@rebtoor rebtoor marked this pull request as ready for review May 15, 2024 10:01
@openshift-ci openshift-ci bot requested review from dasm and dsariel May 15, 2024 10:02
@raukadah
Copy link
Contributor

/lgtm
/approve

tested downstream!

Copy link
Contributor

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e73daa0 into openstack-k8s-operators:main May 16, 2024
5 checks passed
@rebtoor rebtoor deleted the kubectl_kustomize branch September 23, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants