Don't hardcode device image file in unit template #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cifmw_block_device role creatas a systemd unit that harcodes the device image file to user for ceph-osd-losetup. Instead it should use the cifmw_block_device_image_file var, since that var will always point to correct path for the file (as it has a default).
|
Skipping CI for Draft Pull Request. |
fultonj
approved these changes
May 15, 2024
fultonj
reviewed
May 15, 2024
| @@ -9,7 +9,7 @@ After=syslog.target | |||
| [Service] | |||
| Type=oneshot | |||
| ExecStart=/bin/bash -c '/sbin/losetup {{ cifmw_block_device_loop }} || \ | |||
| /sbin/losetup {{ cifmw_block_device_loop }} /var/lib/ceph-osd.img ; partprobe {{ cifmw_block_device_loop }}' | |||
| /sbin/losetup {{ cifmw_block_device_loop }} {{ cifmw_block_device_image_file }} ; partprobe {{ cifmw_block_device_loop }}' | |||
There was a problem hiding this comment.
Yes, we have the same default for this value and should use the variable in case someone overrides it.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjeanner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cifmw_block_device role creatas a systemd unit that harcodes the
device image file to user for ceph-osd-losetup. Instead it should use
the cifmw_block_device_image_file var, since that var will always point
to correct path for the file (as it has a default).
As a pull request owner and reviewers, I checked that: