Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure to run cephfs task for nfs ganesha #1713

Merged
merged 1 commit into from
May 30, 2024
Merged

Ensure to run cephfs task for nfs ganesha #1713

merged 1 commit into from
May 30, 2024

Conversation

katarimanojk
Copy link
Contributor

@katarimanojk katarimanojk commented May 16, 2024 •
edited
Loading

This patch updates when condition for cephfs task in ceph playbook so that nfs ganesha deployment is never skipped if ceph_nfs_enabled is true.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

@katarimanojk katarimanojk requested a review from fmount May 16, 2024 06:59
@openshift-ci openshift-ci bot requested review from son-vyas and viroel May 16, 2024 06:59
@github-actions github-actions bot marked this pull request as draft May 16, 2024 06:59
@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@katarimanojk katarimanojk self-assigned this May 16, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a33105a5e65444be81d7c0c18ed7e484

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 08m 20s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 22m 42s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 21m 44s
✔️ podified-multinode-hci-deployment-crc SUCCESS in 1h 47m 48s
✔️ noop SUCCESS in 0s
❌ cifmw-pod-ansible-test FAILURE in 4m 52s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 56s

@katarimanojk katarimanojk force-pushed the ensure_cephnfs_task_is_run branch from 8793208 to 6b927d7 Compare May 16, 2024 11:24
fmount
fmount requested changes May 16, 2024
View reviewed changes
playbooks/ceph.yml Outdated Show resolved Hide resolved
@katarimanojk katarimanojk force-pushed the ensure_cephnfs_task_is_run branch from 6b927d7 to 5b7e2f7 Compare May 23, 2024 13:55
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/62d98e17ad2f48d494b12a486c95e85a

✔️ openstack-k8s-operators-content-provider SUCCESS in 4h 24m 26s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 1h 17m 03s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 14m 47s
❌ podified-multinode-hci-deployment-crc FAILURE in 1h 40m 36s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 54s
❌ cifmw-pod-pre-commit FAILURE in 8m 31s
✔️ cifmw-molecule-cifmw_cephadm SUCCESS in 4m 57s

@katarimanojk katarimanojk force-pushed the ensure_cephnfs_task_is_run branch from 5b7e2f7 to 67e8fcc Compare May 27, 2024 11:26
@katarimanojk katarimanojk requested a review from fmount May 27, 2024 11:28
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ee48fa4517f84711bd7284bb4a2da2fb

❌ openstack-k8s-operators-content-provider MERGE_CONFLICT in 7s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ podified-multinode-hci-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
❌ cifmw-pod-ansible-test MERGE_CONFLICT in 1s
❌ cifmw-pod-pre-commit MERGE_CONFLICT in 1s
❌ cifmw-molecule-cifmw_cephadm MERGE_CONFLICT in 1s

@katarimanojk katarimanojk force-pushed the ensure_cephnfs_task_is_run branch from 67e8fcc to 10de4a6 Compare May 28, 2024 04:11
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b41646f8e22a4ed19df4dc0c0886245a

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 59m 40s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 37s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 11m 26s
❌ podified-multinode-hci-deployment-crc FAILURE in 1h 41m 18s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 41s
❌ cifmw-pod-pre-commit FAILURE in 7m 24s
✔️ cifmw-molecule-cifmw_cephadm SUCCESS in 5m 56s

fmount
fmount reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • fix the comment pointed by tosky
  • rebase against main

roles/cifmw_cephadm/tasks/cephnfs.yml Outdated Show resolved Hide resolved
playbooks/ceph.yml Outdated Show resolved Hide resolved
@katarimanojk katarimanojk force-pushed the ensure_cephnfs_task_is_run branch from 10de4a6 to 0028e3a Compare May 28, 2024 07:12
@katarimanojk
Copy link
Contributor Author

  • fix the comment pointed by tosky
  • rebase against main

Done

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/faf9e10263cb4e2db87477c6d5824ee0

❌ openstack-k8s-operators-content-provider FAILURE in 10m 16s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ podified-multinode-hci-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 04s
❌ cifmw-pod-pre-commit FAILURE in 8m 43s
✔️ cifmw-molecule-cifmw_cephadm SUCCESS in 6m 15s

@tosky
Copy link
Contributor

tosky commented May 28, 2024

Fine by me if the gates are fine. Time to remove the work-in-progress label?

@katarimanojk katarimanojk marked this pull request as ready for review May 28, 2024 08:07
@katarimanojk
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/638e5dca3fb644e2a5f58076cc047d3a

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 15m 22s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 34s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 10m 07s
❌ podified-multinode-hci-deployment-crc FAILURE in 1h 46m 44s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 25s
❌ cifmw-pod-pre-commit FAILURE in 30m 31s
✔️ cifmw-molecule-cifmw_cephadm SUCCESS in 4m 49s

@tosky
Copy link
Contributor

tosky commented May 29, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/646511baee864200af2a676a1c275f6a

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 01m 55s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 02s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 14m 15s
✔️ podified-multinode-hci-deployment-crc SUCCESS in 1h 46m 04s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 32s
❌ cifmw-pod-pre-commit FAILURE in 7m 29s
✔️ cifmw-molecule-cifmw_cephadm SUCCESS in 4m 44s

@katarimanojk katarimanojk force-pushed the ensure_cephnfs_task_is_run branch from 0028e3a to 32f9736 Compare May 29, 2024 14:33
@tosky
Copy link
Contributor

tosky commented May 29, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 29, 2024
@fmount fmount requested a review from rebtoor May 29, 2024 21:44
@fmount
Copy link
Contributor

fmount commented May 29, 2024

/lgtm

@katarimanojk katarimanojk requested a review from pablintino May 30, 2024 09:52
rebtoor
rebtoor reviewed May 30, 2024
View reviewed changes
playbooks/ceph.yml Outdated Show resolved Hide resolved
@katarimanojk
Ensure to run cephfs task for nfs ganesha
a40d2d3 
This patch updates when condition for cephfs task in ceph
playbook so that nfs ganesha deployment is never skipped if
ceph_nfs_enabled is true.
@katarimanojk katarimanojk force-pushed the ensure_cephnfs_task_is_run branch from 32f9736 to a40d2d3 Compare May 30, 2024 10:35
@openshift-ci openshift-ci bot removed the lgtm label May 30, 2024
@katarimanojk katarimanojk requested a review from rebtoor May 30, 2024 10:36
@openshift-ci openshift-ci bot added the lgtm label May 30, 2024
@rebtoor
Copy link
Contributor

rebtoor commented May 30, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9954735 into openstack-k8s-operators:main May 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmount fmount fmount requested changes

@tosky tosky tosky left review comments

@rebtoor rebtoor rebtoor approved these changes

@son-vyas son-vyas Awaiting requested review from son-vyas

@viroel viroel Awaiting requested review from viroel

@pablintino pablintino Awaiting requested review from pablintino

Assignees

@rebtoor rebtoor

@fmount fmount

@tosky tosky

@katarimanojk katarimanojk

Labels
approved lgtm Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@katarimanojk @tosky @fmount @rebtoor