Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix polarion role for "update test runs task" #1718

Closed

Conversation

son-vyas
Copy link
Contributor

@son-vyas son-vyas commented May 16, 2024

The task is encountering an issue because it expects a list of objects with a path attribute, but instead, it is receiving a
string.
The map(attribute='path') filter is being applied to a string, which causes the error.

To resolve this, ensure that xml_files.files is a list of dictionaries, each containing a path key.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

The task is encountering an issue because
it expects a list of objects with a path
attribute, but instead, it is receiving a
string.
The map(attribute='path') filter is being
applied to a string, which causes the error.

To resolve this, ensure that xml_files.files
is a list of dictionaries, each containing a path key.
@openshift-ci openshift-ci bot requested review from dasm and lewisdenny May 16, 2024 11:29
Copy link
Contributor

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cescgina for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot marked this pull request as draft May 16, 2024 11:29
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

Copy link
Contributor

@arxcruz arxcruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1705 fixes it, this patch is no longer required

@arxcruz
Copy link
Contributor

arxcruz commented May 16, 2024

/dnm

@arxcruz arxcruz added duplicate This issue or pull request already exists and removed Ready For Review labels May 16, 2024
Copy link
Contributor

openshift-ci bot commented May 20, 2024

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@son-vyas son-vyas changed the title Updated the "update test runs task" Fix polarion role for "update test runs task" May 20, 2024
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/63999ba2d1e7433f93c699d6b174a438

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 38m 08s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 55s
cifmw-crc-podified-edpm-baremetal MERGE_CONFLICT in 4s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 15s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 38s
✔️ cifmw-molecule-polarion SUCCESS in 1m 50s

@lewisdenny lewisdenny removed their request for review May 20, 2024 23:22
@son-vyas son-vyas removed duplicate This issue or pull request already exists do-not-merge/contains-merge-commits labels May 22, 2024
@son-vyas son-vyas closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants