Add tolerations and nodeSelector to test-operator-controller-manager #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! ❤️ |
In previous PR [1], tolerations and nodeSelector parameters were added to the test_operator role in order to configure tempest and tobiko pods. This new PR adds the option to apply those parameters to the test-operator-controller-manager and test-operator-logs pod as well. [1] openstack-k8s-operators#1716
eduolivares
force-pushed
the
tolerations-test-operator-controller
branch
from
9906a13 to
b03b40d
Compare
|
New changes are detected. LGTM label has been removed. |
kopecmartin
approved these changes
May 17, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 9332a5c
into
openstack-k8s-operators:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous PR [1], tolerations and nodeSelector parameters were added to the test_operator role in order to configure tempest and tobiko pods. This new PR adds the option to apply those parameters to the test-operator-controller-manager and and test-operator-logs pods as well.
[1] #1716
As a pull request owner and reviewers, I checked that: