Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bind-dynamic to dnsmasq conf #1748

Closed

Conversation

hjensas
Copy link
Contributor

@hjensas hjensas commented May 22, 2024

We should enable the bind-dynamic option to allow our DHCP server to co-exist with other DHCP services - such as one for a libvirt network.

Without this the service will fail to start if there is a livirt network with DHCP enabled.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

We should enable the bind-dynamic option to allow our DHCP
server to co-exist with other DHCP services - such as one for
a libvirt network.

Without this the service will fail to start if there is a livirt
network with DHCP enabled.
@openshift-ci openshift-ci bot requested review from bshewale and lewisdenny May 22, 2024 17:27
@github-actions github-actions bot marked this pull request as draft May 22, 2024 17:27
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

Copy link
Contributor

openshift-ci bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign viroel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cjeanner
Copy link
Contributor

@hjensas heya! I'd rather prefer if you could have a look at #1741 and collaborate with @rebtoor to improve that other PR if you don't mind? Thanks!

@hjensas
Copy link
Contributor Author

hjensas commented May 27, 2024

Closing - this is addressed in #1741

@hjensas hjensas closed this May 27, 2024
@hjensas hjensas deleted the dnsmasq-bind-dynamic branch July 3, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants