Remove multi-hypervisor testing in molecule #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
lewisdenny
requested changes
May 27, 2024
This feature will make IPv6 support addition far too complicated for now, and since it's apparently not used nor really advertised, let's "just" stop testing it. Reverting the whole feature would be too complicated as well - and we might want to get it back in the future.
cjeanner
force-pushed
the
libvirt_manager/no-multi-hypervisor-test
branch
from
ef34039 to
c1ef8b7
Compare
|
@lewisdenny there's also an open MR in downstream doc. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
deleted the
libvirt_manager/no-multi-hypervisor-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature will make IPv6 support addition far too complicated for
now, and since it's apparently not used nor really advertised, let's
"just" stop testing it.
Reverting the whole feature would be too complicated as well - and
we might want to get it back in the future.
As a pull request owner and reviewers, I checked that: