Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent the assertion in sushy_emulator #1755

Merged
merged 1 commit into from
May 28, 2024

Conversation

cjeanner
Copy link
Contributor

The output is really huge, and I'm not really sure it provides useful
information as-is.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running

Copy link
Contributor

openshift-ci bot commented May 23, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@cjeanner cjeanner marked this pull request as ready for review May 27, 2024 06:28
The output is really huge, and I'm not really sure it provides useful
information as-is.
@openshift-ci openshift-ci bot requested review from marios and rlandy May 27, 2024 06:28
@cjeanner cjeanner force-pushed the sushy_emulator/silent-assert branch from 0cfb2c6 to 09f2800 Compare May 27, 2024 06:28
Copy link
Collaborator

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@raukadah
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5696c2c into main May 28, 2024
5 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the sushy_emulator/silent-assert branch May 28, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants