Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci lvms storage no zuul #1759

Closed

Conversation

fultonj
Copy link
Contributor

@fultonj fultonj commented May 23, 2024

DNM - Test ci_lvms_storage PR 1707

We need to drop zuul.d changes from ci-framework change in order to test downstream. Known issue with downstream.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

The ci_lvms_storage role aims to be a drop in replacement
for ci_local_storage. It uses LVMS (Logical Volume Manager
Storage) based on the TopoLVM CSI driver to dynamically
provision local storage built from block devices on OCP
nodes.

This role requires cifmw_lvms_disk_list to contain a list of
paths to block devices which already exist on OCP nodes. If
the cifmw_devscripts_config_overrides.vm_extradisks_list list
contains "vda vdb", then it will create these block devices and
cifmw_lvms_disk_list should be set to ['/dev/vda', '/dev/vdb'].
This role will then pass this list to the deviceSelector list
used by the LVMCluster CRD.

This patch introduces the role but ci_local_storage is still
used by the 06-deploy-{architecture,edpm}.yml playbooks unless
cifmw_use_lvms is true. The ci_gen_kustomize_values role is
updated to set the storageClass to lvms-local-storage only if
cifmw_use_lvms is true. Otherwise it keeps its default of
local-storage. A similar change has been made to the role
test_operator so that Tempest uses the chosen storage class.

In a follow up patch we can default cifmw_use_lvms to true so
LVMS becomes opt out. For now it is opt in for early testing.

Signed-off-by: John Fulton <[email protected]>
Related: https://issues.redhat.com/browse/OSPRH-2749
@openshift-ci openshift-ci bot requested review from afazekas and psathyan May 23, 2024 15:46
Copy link
Contributor

openshift-ci bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cjeanner for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot marked this pull request as draft May 23, 2024 15:46
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@fultonj fultonj requested review from rlandy and removed request for afazekas and psathyan May 23, 2024 15:46
We need to drop zuul.d changes from ci-framework change in order
to test downstream. Known issue with downstream.
@fultonj fultonj force-pushed the ci_lvms_storage_no_zuul branch from 541bde6 to 189df0b Compare May 23, 2024 17:40
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5f59cb9e303c4f91a8d0a6e0bc0985f4

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 24m 25s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 18m 26s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 11m 26s
podified-multinode-hci-deployment-crc FAILURE in 1h 42m 13s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 31m 33s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 53s
✔️ cifmw-pod-k8s-snippets-source SUCCESS in 5m 04s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 26s
✔️ cifmw-architecture-validate-hci SUCCESS in 6m 06s
✔️ cifmw-molecule-ci_gen_kustomize_values SUCCESS in 5m 43s
✔️ cifmw-molecule-test_operator SUCCESS in 3m 53s

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fultonj
Copy link
Contributor Author

fultonj commented Jun 6, 2024

This was only made to test PR 1707 which has since merged.

@fultonj fultonj closed this Jun 6, 2024
@fultonj fultonj deleted the ci_lvms_storage_no_zuul branch January 28, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants