Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: Correct the used SSH key in ansible inventory #1774

Merged
merged 1 commit into from
May 29, 2024

Conversation

cjeanner
Copy link
Contributor

@cjeanner cjeanner commented May 28, 2024

We were missing the right ssh key configuration in the generated ansible
inventory, leading to "some" issues.

We also ensure ansible won't complain about the remote host keys. A
better solution might come later, once we're over the deep network
refactoring

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running

@cjeanner cjeanner force-pushed the libvirt_manager/correct-used-ssh-key branch 2 times, most recently from 3562c22 to b3e7d04 Compare May 28, 2024 17:52
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/80e42e8d53544f469e2e27438408559d

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 51m 12s
podified-multinode-edpm-deployment-crc POST_FAILURE in 1h 32m 05s
cifmw-crc-podified-edpm-baremetal MERGE_CONFLICT in 3s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 52s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 57s
✔️ cifmw-baremetal-nested-crc SUCCESS in 1h 05m 37s
✔️ cifmw-molecule-libvirt_manager SUCCESS in 12m 40s
✔️ cifmw-molecule-reproducer SUCCESS in 16m 31s

We were missing the right ssh key configuration in the generated ansible
inventory, leading to "some" issues.

We also ensure ansible won't complain about the remote host keys. A
better solution might come later, once we're over the deep network
refactoring
@psathyan psathyan force-pushed the libvirt_manager/correct-used-ssh-key branch from b3e7d04 to 1ebb57e Compare May 29, 2024 02:42
@openshift-ci openshift-ci bot removed the lgtm label May 29, 2024
@openshift-ci openshift-ci bot added the lgtm label May 29, 2024
@raukadah
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8ee922c into main May 29, 2024
5 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the libvirt_manager/correct-used-ssh-key branch May 29, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants