Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some hardcoded repository locations #1783

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

viroel
Copy link
Contributor

@viroel viroel commented May 29, 2024

While deploying with a different repository location we found these 2 places that have code location hardcoded. This PR allow these commands to check for cifmw known vaiables for these specific repositories.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

While deploying with a different repository location we
found these 2 places that have code location hardcoded.
This PR allow these commands to check for cifmw known
vaiables for these specific repositories.
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@github-actions github-actions bot marked this pull request as draft May 29, 2024 15:32
@viroel viroel marked this pull request as ready for review May 29, 2024 16:50
@openshift-ci openshift-ci bot added the lgtm label Jun 3, 2024
Copy link
Collaborator

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks Doug!

Copy link
Contributor

openshift-ci bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lewisdenny

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ec4277b into main Jun 3, 2024
7 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the fix_hardcoded_paths branch June 3, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants