Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsmasq manage forwarder/address/host-record #1785

Merged

Conversation

hjensas
Copy link
Contributor

@hjensas hjensas commented May 29, 2024

Add task files to the dnsmasq role to manage forwarder, address and host-record config to the running dnsmasq server.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

@hjensas hjensas requested a review from rebtoor May 29, 2024 18:08
@github-actions github-actions bot marked this pull request as draft May 29, 2024 18:08
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/63c1519fe4f84bcfa9bda2a12132b1be

✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 13s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 01s
cifmw-molecule-dnsmasq FAILURE in 4m 46s

@hjensas hjensas force-pushed the dnsmasq-manage-tasks branch from e9c08e4 to bc2573f Compare May 29, 2024 18:24
Add task files to the dnsmasq role to manage forwarder, address and
host-record config to the running dnsmasq server.
@hjensas hjensas force-pushed the dnsmasq-manage-tasks branch from bc2573f to e5b3b1c Compare May 29, 2024 18:31
@hjensas hjensas marked this pull request as ready for review May 29, 2024 18:50
@rebtoor
Copy link
Contributor

rebtoor commented May 30, 2024

Hey @hjensas, thanks for the PR!

Since you have implemented forwarder and addresses configurations through new taskfiles and vars, care to remove dns.yml and its vars?

@rebtoor
Copy link
Contributor

rebtoor commented May 30, 2024

/approve

Copy link
Contributor

openshift-ci bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit da68b14 into openstack-k8s-operators:main May 30, 2024
7 checks passed
@hjensas hjensas deleted the dnsmasq-manage-tasks branch June 20, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants