Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed validate-architecture zuul job #1816

Conversation

rebtoor
Copy link
Contributor

@rebtoor rebtoor commented Jun 3, 2024

  • Fixed file name generation typo in validate-architecture playbook
  • Added the ability of overriding cifmw_networking_mapper_networking_env_def_path job

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running

Copy link
Contributor

openshift-ci bot commented Jun 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

Zuul encountered a syntax error while parsing its configuration in the
repo openstack-k8s-operators/ci-framework on branch main. The error
was:

Invalid Ansible variable name '_cifmw_networking_env_def_file' for dictionary value @ data['vars']

The error appears in the following job stanza:

job:
name: cifmw-architecture-validate-base
parent: cifmw-base-minimal
vars:
cifmw_architecture_repo: >-
{{
[ansible_user_dir,
zuul.projects['github.com/openstack-k8s-operators/architecture'].src_dir]
| path_join
}}
_cifmw_networking_env_def_file: >-
{{
([ cifmw_architecture_repo,
cifmw_networking_env_dev_file ] | path_join) if cifmw_networking_env_def_file
}}
cifmw_networking_mapper_networking_env_def_path: >-
{{
_cifmw_networking_env_def_file |
default([ansible_user_dir,
zuul.projects['github.com/openstack-k8s-operators/ci-framework'].src_dir,
'ci/playbooks/files/networking-env-definition.yml'] | path_join)
}}
run:
- ci/playbooks/architecture/run.yml
required-projects:
- openstack-k8s-operators/architecture

in "openstack-k8s-operators/ci-framework/zuul.d/architecture-jobs.yaml@main", line 8, column 3

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/6f47d0d8fe06461ca73371719b5a751a

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 38m 55s
podified-multinode-edpm-deployment-crc RETRY_LIMIT in 5s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 5s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 37s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 40s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 40s
✔️ cifmw-architecture-validate-hci SUCCESS in 3m 45s

@rebtoor rebtoor force-pushed the fix-validate-architecture-job branch 2 times, most recently from f621fa1 to f2425c2 Compare June 5, 2024 14:43
@rebtoor rebtoor marked this pull request as ready for review June 5, 2024 14:53
@rebtoor rebtoor requested review from cjeanner and pablintino June 5, 2024 14:53
@rebtoor rebtoor force-pushed the fix-validate-architecture-job branch from f2425c2 to fe06786 Compare June 6, 2024 09:01
@rebtoor rebtoor force-pushed the fix-validate-architecture-job branch from fe06786 to 8d1092a Compare June 6, 2024 09:09
@rebtoor rebtoor force-pushed the fix-validate-architecture-job branch from 8d1092a to 520ae5f Compare June 6, 2024 11:59
@rebtoor rebtoor force-pushed the fix-validate-architecture-job branch from 520ae5f to fdbe16d Compare June 6, 2024 13:24
@rebtoor rebtoor requested a review from pablintino June 6, 2024 14:15
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/fff32dc0550c49508e5d3c4a0073a2b5

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 14m 16s
podified-multinode-edpm-deployment-crc POST_FAILURE in 1h 13m 50s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 20m 57s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 48s
✔️ cifmw-pod-pre-commit SUCCESS in 9m 23s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 32s
✔️ cifmw-architecture-validate-hci SUCCESS in 4m 37s

@pablintino
Copy link
Collaborator

recheck

@pablintino
Copy link
Collaborator

/approve
The failed job shouldn't be related.

@openshift-ci openshift-ci bot added the approved label Jun 7, 2024
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/4f31eab85abc4f1b93d49e6d55fc640c

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 36m 53s
podified-multinode-edpm-deployment-crc FAILURE in 1h 40m 21s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 30m 01s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 57s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 54s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 41s
✔️ cifmw-architecture-validate-hci SUCCESS in 4m 40s

* Fixed file name generation typo in `validate-architecture` playbook
* Added the ability of overriding
  `cifmw_networking_mapper_networking_env_def_path` job

Signed-off-by: Roberto Alfieri <[email protected]>
@rebtoor rebtoor force-pushed the fix-validate-architecture-job branch from fdbe16d to 1fa939a Compare June 11, 2024 08:01
@pablintino
Copy link
Collaborator

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Jun 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 53910f5 into openstack-k8s-operators:main Jun 11, 2024
5 checks passed
softwarefactory-project-zuul bot added a commit to openstack-k8s-operators/architecture that referenced this pull request Jun 11, 2024
…f-mock-files

Use uni* specific Net Env Def in CI

Depends-On: openstack-k8s-operators/ci-framework#1816

Reviewed-by: John Fulton <[email protected]>
@rebtoor rebtoor deleted the fix-validate-architecture-job branch September 23, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants