Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added .vscode to .gitignore file #1820

Merged

Conversation

rebtoor
Copy link
Contributor

@rebtoor rebtoor commented Jun 4, 2024

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running

Signed-off-by: Roberto Alfieri <[email protected]>
Copy link

github-actions bot commented Jun 4, 2024

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@github-actions github-actions bot marked this pull request as draft June 4, 2024 08:17
@cescgina
Copy link
Contributor

cescgina commented Jun 4, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cescgina

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 4, 2024
@fao89 fao89 marked this pull request as ready for review June 4, 2024 08:32
@openshift-ci openshift-ci bot added the lgtm label Jun 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e1f050b into openstack-k8s-operators:main Jun 4, 2024
7 checks passed
@rebtoor rebtoor deleted the gitignore-vscode branch September 23, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants