Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compute VMs specs configurable for 3-nodes scenario #1824

Conversation

mandre
Copy link
Contributor

@mandre mandre commented Jun 4, 2024

Replicate what was made for the va-hci scenario.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

Copy link
Contributor

openshift-ci bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign abays for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot marked this pull request as draft June 4, 2024 15:47
Copy link
Contributor

openshift-ci bot commented Jun 4, 2024

Hi @mandre. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

github-actions bot commented Jun 4, 2024

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a8051585f9d04888bf7fe876cc1ded29

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 35m 35s
podified-multinode-edpm-deployment-crc FAILURE in 1h 07m 25s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 18m 56s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 21s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 22s

@mandre mandre force-pushed the configurable-computes-3-nodes branch from 2d4ec95 to ec0c3be Compare June 5, 2024 06:20
Replicate what was made for the va-hci scenario.
@mandre mandre force-pushed the configurable-computes-3-nodes branch from ec0c3be to 1c3f0f6 Compare June 5, 2024 06:22
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/3ad02bf547c946168a86ef045a0e037c

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 30m 55s
podified-multinode-edpm-deployment-crc RETRY_LIMIT in 6m 38s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 13m 43s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 29s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 12s

@mandre
Copy link
Contributor Author

mandre commented Jun 5, 2024

recheck

@cjeanner
Copy link
Contributor

cjeanner commented Jul 3, 2024

/ok-to-test

Note that you can "patch" the layout directly:

cifmw_libvirt_manager_layout_patch_01_compute_resources:
  vms:
    compute:
      cpus: 10
      memory: 24
      disksize: 100

So I'm not really sure this PR is needed with that feature ?

@pablintino
Copy link
Collaborator

Stale and theoretically supported by using patches.

@pablintino pablintino closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants