Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip validations in edpm deploy for arch deployment #1828

Conversation

bshephar
Copy link
Contributor

@bshephar bshephar commented Jun 4, 2024

When running an architecture deployment, most of the control plane and dataplane setup are skipped in 06-edpm-deploy.yml. Instead, it all gets configured in the 06-deploy-architecture.yml playbook. This means that we need to also skip validations in the 06-epdm-deploy.yml since there is nothing to validate at this stage. We will instead fall back to the validations role execution in the architecture playbook.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

Copy link

github-actions bot commented Jun 4, 2024

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@github-actions github-actions bot marked this pull request as draft June 4, 2024 23:20
@bshephar bshephar marked this pull request as ready for review June 4, 2024 23:20
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/0d420e753db94d33b267386ce6b2b3b6

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 23m 56s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 25m 03s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 18m 28s
✔️ podified-multinode-hci-deployment-crc SUCCESS in 1h 42m 41s
cifmw-data-plane-adoption-osp-17-to-extracted-crc FAILURE in 2h 04m 46s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 07s
cifmw-pod-pre-commit FAILURE in 7m 08s

When running an architecture deployment, most of the control plane and dataplane setup
are skipped in 06-edpm-deploy.yml. Instead, it all gets configured in the 06-deploy-architecture.yml
playbook. This means that we need to also skip validations in the 06-epdm-deploy.yml since there is
nothing to validate at this stage. We will instead fall back to the validations role execution in
the architecture playbook.

Signed-off-by: Brendan Shephard <[email protected]>
@bshephar bshephar force-pushed the skip-validations-edpm-deploy branch from 623ac63 to 9d392ad Compare June 5, 2024 04:16
Copy link
Collaborator

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@pablintino
Copy link
Collaborator

/approve

Copy link
Contributor

openshift-ci bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lewisdenny, pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lewisdenny,pablintino]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/4cca697bb04e4895b1326644c1bd7033

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 16m 12s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 21m 42s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 15m 40s
✔️ podified-multinode-hci-deployment-crc SUCCESS in 1h 51m 14s
cifmw-data-plane-adoption-osp-17-to-extracted-crc FAILURE in 1h 58m 12s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 14s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 30s

@bshephar
Copy link
Contributor Author

bshephar commented Jun 5, 2024

Ok, this is failing now because of the known issue with deploying Heat in the data-plane-adoption job:

TASK [heat_adoption : deploy podified heat] ************************************
fatal: [localhost]: FAILED! => {"changed": true, "cmd": "set -euxo pipefail\n\n\noc patch openstackcontrolplane openstack --type=merge --patch '\nspec:\n  heat:\n    enabled: true\n    apiOverride:\n      route: {}\n    template:\n      databaseInstance: openstack\n      databaseAccount: heat\n      secret: osp-secret\n      memcachedInstance: memcached\n      passwordSelectors:\n        authEncryptionKey: HeatAuthEncryptionKey\n        database: HeatDatabasePassword\n        service: HeatPassword\n'\n", "delta": "0:00:00.303161", "end": "2024-06-05 02:18:03.489983", "msg": "non-zero return code", "rc": 1, "start": "2024-06-05 02:18:03.186822", "stderr": "+ oc patch openstackcontrolplane openstack --type=merge --patch '\nspec:\n  heat:\n    enabled: true\n    apiOverride:\n      route: {}\n    template:\n      databaseInstance: openstack\n      databaseAccount: heat\n      secret: osp-secret\n      memcachedInstance: memcached\n      passwordSelectors:\n        authEncryptionKey: HeatAuthEncryptionKey\n        database: HeatDatabasePassword\n        service: HeatPassword\n'\nWarning: unknown field \"spec.heat.template.passwordSelectors.database\"\nThe OpenStackControlPlane \"openstack\" is invalid: spec.databaseInstance: Forbidden: Changing the DatabaseInstance is not supported for existing deployments", "stderr_lines": ["+ oc patch openstackcontrolplane openstack --type=merge --patch '", "spec:", "  heat:", "    enabled: true", "    apiOverride:", "      route: {}", "    template:", "      databaseInstance: openstack", "      databaseAccount: heat", "      secret: osp-secret", "      memcachedInstance: memcached", "      passwordSelectors:", "        authEncryptionKey: HeatAuthEncryptionKey", "        database: HeatDatabasePassword", "        service: HeatPassword", "'", "Warning: unknown field \"spec.heat.template.passwordSelectors.database\"", "The OpenStackControlPlane \"openstack\" is invalid: spec.databaseInstance: Forbidden: Changing the DatabaseInstance is not supported for existing deployments"], "stdout": "", "stdout_lines": []}

openstack-k8s-operators/data-plane-adoption#480 (review)

@bshephar
Copy link
Contributor Author

bshephar commented Jun 6, 2024

recheck

@openshift-merge-bot openshift-merge-bot bot merged commit 69128cb into openstack-k8s-operators:main Jun 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants