-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip validations in edpm deploy for arch deployment #1828
Skip validations in edpm deploy for arch deployment #1828
Conversation
Thanks for the PR! ❤️ |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/0d420e753db94d33b267386ce6b2b3b6 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 23m 56s |
When running an architecture deployment, most of the control plane and dataplane setup are skipped in 06-edpm-deploy.yml. Instead, it all gets configured in the 06-deploy-architecture.yml playbook. This means that we need to also skip validations in the 06-epdm-deploy.yml since there is nothing to validate at this stage. We will instead fall back to the validations role execution in the architecture playbook. Signed-off-by: Brendan Shephard <[email protected]>
623ac63
to
9d392ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lewisdenny, pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/4cca697bb04e4895b1326644c1bd7033 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 16m 12s |
Ok, this is failing now because of the known issue with deploying Heat in the data-plane-adoption job:
|
recheck |
69128cb
into
openstack-k8s-operators:main
When running an architecture deployment, most of the control plane and dataplane setup are skipped in 06-edpm-deploy.yml. Instead, it all gets configured in the 06-deploy-architecture.yml playbook. This means that we need to also skip validations in the 06-epdm-deploy.yml since there is nothing to validate at this stage. We will instead fall back to the validations role execution in the architecture playbook.
As a pull request owner and reviewers, I checked that: