[networking_mapper] Make null templates behave like an empty one #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, if the data inside a template network is null the mapper will raise an unhandled exception, that may be fine, but for this particular case making null and empty behave the same way will allow the mapper to raise a meaningful error letting him know the field cannot be empty as some child elements are mandatory.
|
Thanks for the PR! ❤️ |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjeanner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rebtoor
approved these changes
Jun 5, 2024
openshift-merge-bot
bot
deleted the
networking_mapper/assume-null-templates-are-empty-ones
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, if the data inside a template network is null the mapper will raise an unhandled exception, that may be fine, but for this particular case making null and empty behave the same way will allow the mapper to raise a meaningful error letting him know the field cannot be empty as some child elements are mandatory.
As a pull request owner and reviewers, I checked that: