Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bgp_dt01 templates #1840

Merged

Conversation

eduolivares
Copy link
Contributor

@eduolivares eduolivares commented Jun 5, 2024

bgp_dt01 network-values templates need to be adapted to changes from: openstack-k8s-operators/architecture#264

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running

bgp_dt01 network-values templates need to be adapted to changed from:
openstack-k8s-operators/architecture#264
Copy link

github-actions bot commented Jun 5, 2024

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@pablintino
Copy link
Collaborator

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit bb08857 into openstack-k8s-operators:main Jun 6, 2024
7 of 8 checks passed
@eduolivares eduolivares deleted the bgp-fix-nads branch June 6, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants