Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hook ironic_network - neutron availability zone #1886

Conversation

hjensas
Copy link
Contributor

@hjensas hjensas commented Jun 17, 2024

Add variable _availability_zone_hints. Defaults to null. When a list of one or more availability zone hints are defined the network create command includes the --availability-zone-hint option so that the networks availability zone hints are set.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

Add variable _availability_zone_hints. Defaults to `[]`.
When a list of one or more availability zone hints are defined the
network create command includes the --availability-zone-hint option so
that the networks availability zone hints are set.
@github-actions github-actions bot marked this pull request as draft June 17, 2024 08:51
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@hjensas hjensas marked this pull request as ready for review June 17, 2024 08:51
@hjensas hjensas added the uni01alpha uni01alpha related patches label Jun 17, 2024
@hjensas hjensas requested a review from raukadah June 17, 2024 13:54
Copy link
Contributor

@raukadah raukadah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2ef6e09 into openstack-k8s-operators:main Jun 17, 2024
12 checks passed
@hjensas hjensas deleted the ironic-network-hook-availability-zone branch June 28, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants