-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add create xml results file to validations role #2538
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @drosenfe. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thanks for the PR! ❤️ |
@pablintino cc: @bshephar Sorry for messing up the original review. This is the same as what was reviewed before except that xml files are generated using junitparser. The original comment was to use an ansible template. I think there are several advantages to junitparser. It keeps track of the overall time as well as the total number of tests/failures. Its also what tempest operator uses. What do you think about using junitparser? |
Hi @drosenfe @pablintino, I see there is an alternative patch submitted for this: #2560 Which route will we go? |
@lewisdenny @pablintino Was on PTO last week. I'm fine with using #2560 I've been testing that one. Last comment on slack was that in the xml file being generated the failure reason is not quoted like the other fields and doesn't start with message= Do we want to change that? |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Superseded by #2560 |
Create an xml file of validations results. This is necessary for polarion posting. Note: this is finishing PR #2456 which I messed up. Thought it would be easier to just create a new PR.