Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create xml results file to validations role #2538

Closed

Conversation

drosenfe
Copy link
Contributor

Create an xml file of validations results. This is necessary for polarion posting. Note: this is finishing PR #2456 which I messed up. Thought it would be easier to just create a new PR.

Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cescgina for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

Hi @drosenfe. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions github-actions bot marked this pull request as draft November 13, 2024 20:19
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@drosenfe
Copy link
Contributor Author

@pablintino cc: @bshephar Sorry for messing up the original review. This is the same as what was reviewed before except that xml files are generated using junitparser. The original comment was to use an ansible template. I think there are several advantages to junitparser. It keeps track of the overall time as well as the total number of tests/failures. Its also what tempest operator uses. What do you think about using junitparser?

@lewisdenny
Copy link
Collaborator

lewisdenny commented Nov 28, 2024

Hi @drosenfe @pablintino, I see there is an alternative patch submitted for this: #2560

Which route will we go?

@drosenfe
Copy link
Contributor Author

drosenfe commented Dec 2, 2024

@lewisdenny @pablintino Was on PTO last week. I'm fine with using #2560 I've been testing that one. Last comment on slack was that in the xml file being generated the failure reason is not quoted like the other fields and doesn't start with message= Do we want to change that?

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pablintino
Copy link
Collaborator

Superseded by #2560

@pablintino pablintino closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants