Change the method of installing test-operator #2727
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kstrenkova
force-pushed
the
change-test-operator-installation
branch
from
91e528a to
a900a67
Compare
|
I had a discussion with @lpiwowar. I will change the logic of the patch tomorrow, I am working on it. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5e48c9e0913e4f0b8bec0cb5538021c2 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 54m 53s |
kstrenkova
force-pushed
the
change-test-operator-installation
branch
from
a900a67 to
c6cc2d9
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e3ec121cbf484b43bb0fe5ca0fc284da ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 42m 39s |
roles/test_operator/tasks/main.yml
Outdated
| cmd: >- | ||
| oc patch ClusterServiceVersion {{ (_csvs_out.stdout | from_json).items[0].metadata.name }} | ||
| --type='json' | ||
| -p='[{"op": "replace", "path": "/spec/install/spec/deployments/0/spec/template/spec/containers/0/env/{{ _image_index }}/value", "value": " {{ cifmw_test_operator_index }} "}]' | ||
|
|
||
| - name: Wait until the test-operator csv is present |
There was a problem hiding this comment.
issue (blocking): There is no longer CSV with the test-operator name when we install the test-operator together with the other operators. You probably want to check the openstack-operator CSV and be sure that it is in the Succeeded state after you update the image. It shouldn't be necessary to do that when you are not doing an update of the image.
There was a problem hiding this comment.
Than you for the review! You are right there is no test-operator csv anymore. I have pushed changes that take openstack-operator into consideration. I have still not tested it locally as I seem to not make it work, but at least the logic i pushed for now.
This patch introduces a new way of installing test-operator. Before, we wanted test-operator role to install the test-operator, but now test-operator will be installed the same way as other operators - using openstack-operator. Additionally, there is a need to ensure we can change which version of test-operator is used. This will be necessary for having a way to prevent big issues by changing the versions temporarily.
kstrenkova
force-pushed
the
change-test-operator-installation
branch
from
c6cc2d9 to
cca8a46
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7611c8c4b7c142118f06d3e721a97e9f ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 05m 45s |
This patch introduces a new way of installing test-operator. Before, we wanted test-operator role to install the test-operator, but now test-operator will be installed the same way as other operators - using openstack-operator.
Additionally, there is a need to ensure we can change which version of test-operator is used. This will be necessary for having a way to prevent big issues by changing the versions temporarily.