Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust external network to match HCI greenfield #786

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Adjust external network to match HCI greenfield #786

merged 1 commit into from
Feb 4, 2025

Conversation

ciecierski
Copy link
Contributor

@ciecierski ciecierski commented Jan 16, 2025 •
edited
Loading

@ciecierski ciecierski force-pushed the hci-adoption-ext-net branch from 416fb6b to 844308b Compare January 16, 2025 12:12
ciecierski added a commit to ciecierski/ci-framework that referenced this pull request Jan 16, 2025
@ciecierski
Change external network subnet for data plane adoption hci
3de0193 
Adjust networking_mapper_definition_patch to create external network
as defined data-plane-adoption[1] and architectuere repo

[1]openstack-k8s-operators/data-plane-adoption#786
@ciecierski ciecierski mentioned this pull request Jan 16, 2025
Merged
ciecierski added a commit to ciecierski/ci-framework that referenced this pull request Jan 16, 2025
@ciecierski
Change external network subnet for data plane adoption hci
522d285 
Adjust networking_mapper_definition_patch to create external network
as defined data-plane-adoption[1] and architectuere repo

[1]openstack-k8s-operators/data-plane-adoption#786
ciecierski added a commit to ciecierski/ci-framework that referenced this pull request Jan 16, 2025
@ciecierski
Change external network subnet for data plane adoption hci
06b74ad 
Adjust networking_mapper_definition_patch to create external network
as defined data-plane-adoption[1] and architectuere repo

[1]openstack-k8s-operators/data-plane-adoption#786
@ciecierski ciecierski force-pushed the hci-adoption-ext-net branch from 844308b to 45c0827 Compare January 16, 2025 22:52
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8a8b30dcb83a4f95a78e75f21c7ca470

✔️ noop SUCCESS in 0s
❌ adoption-standalone-to-crc-ceph FAILURE in 1h 39m 31s
❌ adoption-standalone-to-crc-no-ceph FAILURE in 1h 37m 10s

@ciecierski
Copy link
Contributor Author

recheck

holser
holser approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@holser holser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We already tested this on 5-6 machines

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7f52b3fbf3f6430fa191d162750a400f

✔️ noop SUCCESS in 0s
✔️ adoption-standalone-to-crc-ceph SUCCESS in 3h 11m 12s
❌ adoption-standalone-to-crc-no-ceph FAILURE in 1h 56m 32s

@ciecierski
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#2662 is needed.

@ciecierski
Copy link
Contributor Author

/lgtm
adding flag based on testing during workshop

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 27, 2025

@ciecierski: you cannot LGTM your own PR.

In response to this:

/lgtm
adding flag based on testing during workshop

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jistr
Copy link
Contributor

jistr commented Jan 28, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 28, 2025
@jistr
Copy link
Contributor

jistr commented Jan 28, 2025

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/aebb520c95e34513ae1f32b75efd97c1

✔️ noop SUCCESS in 0s
❌ adoption-standalone-to-crc-ceph FAILURE in 1h 39m 38s
❌ adoption-standalone-to-crc-no-ceph FAILURE in 1h 45m 50s

@ciecierski
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e1a3a6406da241ebba5c805d29c9defb

✔️ noop SUCCESS in 0s
❌ adoption-standalone-to-crc-ceph FAILURE in 2h 53m 22s
✔️ adoption-standalone-to-crc-no-ceph SUCCESS in 2h 59m 09s

@ciecierski
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fbfc0d5fc2494c96b2b5c7e3f11a2e26

✔️ noop SUCCESS in 0s
❌ adoption-standalone-to-crc-ceph FAILURE in 2h 50m 46s
✔️ adoption-standalone-to-crc-no-ceph SUCCESS in 2h 53m 44s

@ciecierski ciecierski force-pushed the hci-adoption-ext-net branch from 45c0827 to cbc5e35 Compare February 3, 2025 14:33
@openshift-ci openshift-ci bot removed the lgtm label Feb 3, 2025
@jistr
Copy link
Contributor

jistr commented Feb 4, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 4, 2025
@jistr
Copy link
Contributor

jistr commented Feb 4, 2025

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jistr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 4, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit ae0bf83 into openstack-k8s-operators:main Feb 4, 2025
5 checks passed
ciecierski added a commit to ciecierski/ci-framework that referenced this pull request Feb 4, 2025
@ciecierski
Change external network subnet for data plane adoption hci
5ee311f 
Adjust networking_mapper_definition_patch to create external network
as defined data-plane-adoption[1] and architectuere repo

[1]openstack-k8s-operators/data-plane-adoption#786
tosky pushed a commit to tosky/ci-framework that referenced this pull request Feb 4, 2025
@ciecierski
Change external network subnet for data plane adoption hci
6b9922f 
Adjust networking_mapper_definition_patch to create external network
as defined data-plane-adoption[1] and architectuere repo

[1]openstack-k8s-operators/data-plane-adoption#786
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holser holser holser approved these changes

@cescgina cescgina Awaiting requested review from cescgina

@jistr jistr Awaiting requested review from jistr

Assignees

@jistr jistr

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ciecierski @jistr @holser