Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate control_plane_rollback role calling #808

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

archana203
Copy link
Contributor

@archana203 archana203 commented Feb 10, 2025

Copy link

openshift-ci bot commented Feb 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from archana203. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1e721e161bdf4b72ae6ff411ec897a6c

✔️ noop SUCCESS in 0s
adoption-standalone-to-crc-ceph FAILURE in 1h 32m 08s
adoption-standalone-to-crc-no-ceph FAILURE in 1h 38m 36s

@jistr
Copy link
Contributor

jistr commented Feb 11, 2025

The CI failure is valid. Makefiles prescribe using tabs for indentation, not spaces.

@jistr
Copy link
Contributor

jistr commented Feb 11, 2025

/lgtm

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5fa1d55233c94931809d830b81297a91

✔️ noop SUCCESS in 0s
✔️ adoption-standalone-to-crc-ceph SUCCESS in 3h 30m 01s
adoption-standalone-to-crc-no-ceph RETRY_LIMIT in 47m 55s

Copy link
Contributor

@ciecierski ciecierski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still problem with test-rollback-minimal and test-rollback-with-ceph running both adoption test and rollback in the same Make run.

@archana203
Copy link
Contributor Author

There is still problem with test-rollback-minimal and test-rollback-with-ceph running both adoption test and rollback in the same Make run.
test-rollback-minimal is used in the periodic rollback jobs where the rollback happens after controlplane adoption. We want to separate it just for the development purpose.

@archana203
Copy link
Contributor Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants