Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize podman exporter deployment #870

Conversation

paramite
Copy link
Contributor

This PR re-enables podman_exporter deployment and adds TLS certificates deployment

Partially-Fixes: OSPRH-10788

@openshift-ci openshift-ci bot requested review from vyzigold and yadneshk January 31, 2025 14:58
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/401fce1cdb934ca5ad5e163a7b678fef

✔️ openstack-k8s-operators-content-provider SUCCESS in 4h 04m 44s
podified-multinode-edpm-deployment-crc FAILURE in 1h 40m 03s
cifmw-crc-podified-edpm-baremetal FAILURE in 44m 19s
✔️ noop SUCCESS in 0s
edpm-ansible-tempest-multinode FAILURE in 1h 48m 25s
adoption-standalone-to-crc-ceph-provider FAILURE in 2h 46m 01s

@paramite
Copy link
Contributor Author

paramite commented Feb 3, 2025

recheck

@paramite paramite force-pushed the podman-exporter-tls branch from c909f67 to c9c6488 Compare February 3, 2025 11:05
@jlarriba
Copy link
Contributor

jlarriba commented Feb 3, 2025

/lgtm

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c7f420a237834f32b8a51489211b92ee

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 47m 45s
podified-multinode-edpm-deployment-crc FAILURE in 1h 39m 39s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 40m 14s
✔️ noop SUCCESS in 0s
edpm-ansible-tempest-multinode FAILURE in 1h 45m 00s
adoption-standalone-to-crc-ceph-provider FAILURE in 2h 48m 06s

@paramite
Copy link
Contributor Author

paramite commented Feb 3, 2025

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2bac1c2f57374235b47526e0a983510b

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 33m 31s
podified-multinode-edpm-deployment-crc FAILURE in 1h 38m 32s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 38m 32s
✔️ noop SUCCESS in 0s
edpm-ansible-tempest-multinode FAILURE in 1h 47m 55s
adoption-standalone-to-crc-ceph-provider FAILURE in 2h 47m 46s

Copy link

@vkmc vkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paramite, vkmc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment on lines 118 to 121
loop:
- node_exporter
- podman_exporter
loop_control:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks for the pointer.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/41ab379d6e0d4216aa17227efb75291c

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 38m 32s
podified-multinode-edpm-deployment-crc FAILURE in 1h 38m 26s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 21m 22s
✔️ noop SUCCESS in 0s
edpm-ansible-tempest-multinode FAILURE in 1h 43m 25s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 15m 28s

This PR enables podman_exporter back and add support for TLS certificates.
@paramite paramite force-pushed the podman-exporter-tls branch from f688c38 to 3788ec1 Compare February 4, 2025 15:21
@jlarriba
Copy link
Contributor

jlarriba commented Feb 5, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 5, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 898895d into openstack-k8s-operators:main Feb 5, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants