Tls tidy#498
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6f759dda1e054e68b596298a8ac875c9 ✔️ openstack-k8s-operators-content-provider SUCCESS in 21m 43s |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/13570bf914964cd084a67be97521f50a ❌ openstack-k8s-operators-content-provider FAILURE in 14m 08s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/70f9b8bac7334123b1aff994d0cad453 ❌ openstack-k8s-operators-content-provider FAILURE in 15m 50s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5395d5cca45c40dbac3b7b906e9b7b3e ❌ openstack-k8s-operators-content-provider FAILURE in 15m 53s |
This change splits out the volume and mounts logic into dedicated functions This ultimately makes the deployment logic more legible and easier to test. Signed-off-by: Brendan Shephard <bshephar@redhat.com>
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/66ec123241ea45eda1abe65a8630ddeb ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 32m 22s |
|
/test functional |
|
recheck |
openshift-merge-bot
bot
merged commit 92b9090
into
openstack-k8s-operators:main
3 participants
Move mounts and volumes to dedicated function. This declutters the Deployment logic and makes each component easier to test. Particularly for Heat where we have some challenges with EnvTest and mocking the OpenStack API.