Optmize handling topology logic#519
Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom Apr 15, 2025
Merged
Optmize handling topology logic#519openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
This patch removes the need of using GetLastAppliedTopologyRef to build a topologyRef used by EnsureServiceTopology provided by infra-operator. In particular, we can now blindly pass instance.Status.lastAppliedTopologyRef, and checking that is not nil is deferred to the infra-operator logic [1]. This change also allows to deduplicate most of the common code present in all operators. [1] openstack-k8s-operators/infra-operator#367 Signed-off-by: Francesco Pantano <fpantano@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 8324ba0
into
openstack-k8s-operators:main
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch removes the need of using
GetLastAppliedTopologyRefto build atopologyRefused byEnsureServiceTopologyprovided by infra-operator. In particular, we can now blindly passinstance.Status.LastAppliedTopologyRef, and checking that is not nil is deferred to the infra-operator logic [1]. This change also allows to deduplicate most of the common code present in all operators.As part of the same change, envTests are improved and both
CreateTopologyandGetTopologyfunction calls now rely on infra-operator's implementation.Depends-On: openstack-k8s-operators/infra-operator#367
Jira: https://issues.redhat.com/browse/OSPRH-15412
[1] openstack-k8s-operators/infra-operator#367