Make sure we reconcile heat-engine secrets#521
Conversation
|
Skipping CI for Draft Pull Request. |
bshephar
force-pushed
the
heat-engine-config
branch
from
41760b4 to
086fc0c
Compare
We trigger reconciles for each controller based on different events. This can lead to a situation where Heat engine - which doesn't have the same number of events that will trigger a reconcile, becomes out of sync with the other controllers. For example, the configs which are essentially the same but updated with https endpoints can be synced by the HeatAPI and HeatCfnApi controllers first, before the HeatEngine controller finally catches up. In this interval of time the heat-engine process will fail since it's trying to speak to non https endpoints instead of the correct https ones. This change switches the configMapFn() Watches function to secretFn and switches out instances where we were watching for ConfigMap changes to be watching for secret changes. We don't use ConfigMaps anymore in Heat Operator, so this change was left over from an oversight rather than functionally necessary. Jira: https://issues.redhat.com/browse/OSPCIX-795 Signed-off-by: Brendan Shephard <bshephar@redhat.com>
bshephar
force-pushed
the
heat-engine-config
branch
from
086fc0c to
3fd2561
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 8c44e58
into
openstack-k8s-operators:main
|
/cherry-pick 18.0-fr2 |
|
@stuggi: new pull request created: #522 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
We trigger reconciles for each controllers based on different events. This can lead to a situation where Heat engine - which doesn't have the same number of events that will trigger a reconcile, becomes out of sync with the other controllers. For example, the configs which are essentially the same but updated with https endpoints can be synced by the HeatAPI and HeatCfnApi controllers first, before the HeatEngine controller finally catches up. In this interval of time the heat-engine process will fail since it's trying to speak to non https endpoints instead of the correct https ones.
Jira: https://issues.redhat.com/browse/OSPCIX-795