Skip to content

Enable MTLS memcached auth#537

Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
lmiccini:mtls
Jul 7, 2025
Merged

Enable MTLS memcached auth#537
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
lmiccini:mtls

Conversation

@lmiccini
Copy link
Contributor

This commit allows operators to use mtls as an authentication method against Memcached.
Heat controllers will detect the presence of a purposely-created mtls certificate (authCertSecret) and use this to configure the [cache] and [keystone_authtoken] sections accordingly.
Additional volumes/volumemounts will be appended to each pod.

Note that this commit switches from MemcachedServersWithInet to MemcachedServers since keystone-middleware now uses pymemcache when tls=true and there is no need to use "[]" to enclose the list of memcached servers even for ipv6.

@openshift-ci openshift-ci bot requested review from abays and slagle May 27, 2025 11:39
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e511b44b220640d5aea13c8f405b486b

openstack-k8s-operators-content-provider FAILURE in 8m 26s
⚠️ heat-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e15d39af00cc4ee5a1e2adb8ef4f465d

openstack-k8s-operators-content-provider FAILURE in 8m 55s
⚠️ heat-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/df73549d3369427784e7f57a8fdc49df

openstack-k8s-operators-content-provider FAILURE in 9m 25s
⚠️ heat-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@lmiccini
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/26ef219f74804d1186840b29d1c283b9

openstack-k8s-operators-content-provider FAILURE in 7m 40s
⚠️ heat-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

Copy link
Contributor

@bshephar bshephar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm can you rebase it @lmiccini ?

This commit allows operators to use mtls as an authentication
method against Memcached.
Heat controllers will detect the presence of a purposely-created mtls
certificate (authCertSecret) and use this to configure the
[keystone_authtoken] section accordingly.
Additional volumes/volumemounts will be appended to each pod.

Note that this commit switches from MemcachedServersWithInet to
MemcachedServers as keystone-middleware uses oslo.cache and as such
there is no need to use "[]" to enclose the list of memcached servers even for ipv6.
@bshephar
Copy link
Contributor

bshephar commented Jul 7, 2025

Still lgtm fwiw.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2025

@bshephar: changing LGTM is restricted to collaborators

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, lmiccini, slagle, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c47cd9e into openstack-k8s-operators:main Jul 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants