Add multi-cell tripleo setup for adoption devel #826
Conversation
|
Skipping CI for Draft Pull Request. |
bogdando
force-pushed
the
multi-cell
branch
3 times, most recently
from
e716eef to
a4156c6
Compare
|
This change depends on a change that failed to merge. Change https://review.rdoproject.org/r/c/rdo-jobs/+/53192 is needed. |
There was a problem hiding this comment.
please lets discuss this during tomorrow data plane call before proceeding down this path
i want us all to agree on the direction.
i think you are proposing that we will have a 3 compute hci ceph job, and then a 1 cntrol/2 compute for cells (i.e. this job) but we have not had that conversation yet.
we need to be on the same page about the ci direction since we (ci team) are currently working here
|
This change depends on a change with an invalid configuration. |
|
This change depends on a change with an invalid configuration. |
|
This change depends on a change with an invalid configuration. |
|
This change depends on a change with an invalid configuration. |
|
This change depends on a change with an invalid configuration. |
|
This change depends on a change with an invalid configuration. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
This change depends on a change with an invalid configuration. |
|
This change depends on a change with an invalid configuration. |
|
This change depends on a change with an invalid configuration. |
| set -ex | ||
| sudo dnf install -y podman python3-tripleoclient util-linux lvm2 | ||
|
|
||
| sudo hostnamectl set-hostname undercloud.localdomain | ||
| sudo hostnamectl set-hostname undercloud.localdomain --transient | ||
|
|
||
| cat >\$HOME/nova_noceph.yaml <<__EOF__ |
There was a problem hiding this comment.
why don't we just add this file into the rest of the env files instead of creating like that
i mean, what is special about this one?
There was a problem hiding this comment.
it is a recommended approach in general to provide separate files for different configuration areas, rather than mangling large files.
There was a problem hiding this comment.
i meant more like, we are already carrying a bunch of environment files. Fine if you don't want to put this into an existing one but you can just add a new file under the tripleo directory.
With this we have some environments/parameter_defaults coming from files, and others like this one being created by heredoc. I think it just further adds to the complexity of this 'tool'.
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cf175bde547947759a40abec7c227605 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 49m 13s |
bogdando
force-pushed
the
multi-cell
branch
2 times, most recently
from
8fc0450 to
f396d69
Compare
| # We'll use the NTP_SERVER environmental variable to define the NTP server to use, e.g.: | ||
| # export NTP_SERVER=pool.ntp.org | ||
|
|
||
| if [ $EDPM_COMPUTE_CELLS -eq 2 ] || [ $EDPM_COMPUTE_CELLS -gt 3 ] || [ $EDPM_COMPUTE_CELLS -eq 0 ] ; then |
There was a problem hiding this comment.
like if EDPM_COMPUTE_CELLS != 3 (or whatever the allowed is i think 3?) then error
bogdando
force-pushed
the
multi-cell
branch
from
f396d69 to
643906d
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a1a42f0b465843afabe4a2adb778d530 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 20m 31s |
|
the regression test is passed the multi-node check https://review.rdoproject.org/r/c/testproject/+/54199 ! Now please help testing it downstream, for networker |
In order to keep the HW requirments for development of multi-cell OSP 17.1 adoption for RHOSO 18, provide a reduced multi-stack footprint (which is supported in tripleo, yet not in OSP): undercloud: 1 VM overcloud: Controller0 ( 1 VM, no HA) cell1: Compute0, Compute1 (CellController1) ( 2 VMs) cell2: Compute2+CellController2 (AIO VM host) No Ceph/HCI support yet, TBD. Only a fixed number of cells (2 extra cells) supported yet. Add partial local dev envs support (given VMs preprovisioned): * Fix HOME paths to match the default user home from ssh opts (when it is 'zuul', the commands fail on the control node, when executed from another user name) * Add missing repo setup commands and notes from standalone.sh * Support RH registry auth env vars * Disable undercloud install validations (to allow deployments on low storage envs) * Fix tripleo network config to let it configure nodes in a local setup, where there is no pre-configured networks. * Unplug External network from roles file as CI infra does not provide a gateway for it, so tripleo networking fails ping test Add EDPM_CONFIGURE_NETWORKING to control tripleo networking configuration. Disable it for CI jobs. Should be enabled for local deployments. Add j2 bool filter support to jinja_render common func. Signed-off-by: Bohdan Dobrelia <[email protected]>
bogdando
force-pushed
the
multi-cell
branch
from
643906d to
b236103
Compare
|
recheck |
There was a problem hiding this comment.
networker log looks OK with tripleo deploy complete https://sf.hosted.upshift.rdu2.redhat.com/logs/78/678/02dce54df035fc84769dd16020946b926ebd7a51/check-gitlab-cee/periodic-internal-adoption-multinode-networker-to-crc/26a0f31/controller/ci-framework-data/logs/ci_script_010_run_tripleo.log
Overcloud Deployed successfully
| set -ex | ||
| sudo dnf install -y podman python3-tripleoclient util-linux lvm2 | ||
|
|
||
| sudo hostnamectl set-hostname undercloud.localdomain | ||
| sudo hostnamectl set-hostname undercloud.localdomain --transient | ||
|
|
||
| cat >\$HOME/nova_noceph.yaml <<__EOF__ |
There was a problem hiding this comment.
i meant more like, we are already carrying a bunch of environment files. Fine if you don't want to put this into an existing one but you can just add a new file under the tripleo directory.
With this we have some environments/parameter_defaults coming from files, and others like this one being created by heredoc. I think it just further adds to the complexity of this 'tool'.
|
can we merge this now please? |
|
@jistr PTAL |
| # We'll use the NTP_SERVER environmental variable to define the NTP server to use, e.g.: | ||
| # export NTP_SERVER=pool.ntp.org | ||
|
|
||
| if [ $EDPM_COMPUTE_CELLS -eq 2 ] || [ $EDPM_COMPUTE_CELLS -gt 3 ] || [ $EDPM_COMPUTE_CELLS -eq 0 ] ; then |
There was a problem hiding this comment.
if [ $EDPM_COMPUTE_CELLS -ne 1 -a $EDPM_COMPUTE_CELLS -ne 3 ]; then ...
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bogdando, fao89, marios The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
openshift-merge-bot
bot
merged commit 316ec1e
into
openstack-k8s-operators:main
|
@olliewalsh I will address your comments in follow up, sorry. done #909 |
| @@ -15,11 +15,32 @@ | |||
| # under the License. | |||
| set -ex | |||
|
|
|||
There was a problem hiding this comment.
@bogdando please check slack when you get some time
this breaks the ceph job (your test ran multinode-no-ceph) so please have a look and if we cannot find a good solution today then we can revert and work it out before going again
The default ntp server pool.ntp.org do not work with RH Network, Fix doc so user set it as per the environment. It was correct until [1]. [1] openstack-k8s-operators/install_yamls#826
In order to keep the HW requirments for development
of multi-cell OSP 17.1 adoption for RHOSO 18, provide
a reduced multi-stack footprint
(which is supported in tripleo, yet not in OSP):
undercloud: 1 VM
overcloud: Controller0 ( 1 VM, no HA)
cell1: Compute0, Compute1 (CellController1) ( 2 VMs)
cell2: Compute2+CellController2 (AIO VM host)
No Ceph/HCI support yet, TBD.
Only a fixed number of cells (2 extra cells) supported yet.
Add partial local dev envs support (given VMs preprovisioned):
(when it is 'zuul', the commands fail on the control node,
when executed from another user name)
on low storage envs)
setup, where there is no pre-configured networks
provide a gateway for it, so tripleo networking fails ping test
Add EDPM_CONFIGURE_NETWORKING to control tripleo networking
configuration. Disable it for CI jobs. Should be enabled for
local deployments.
Add j2 bool filter support to jinja_render common func.
Required-By: https://review.rdoproject.org/r/c/rdo-jobs/+/53192
JIRA OSPRH-6548