Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add DatabaseAccount and migrate to MariaDBAccount #398

Merged
merged 1 commit into from
Mar 11, 2024
Merged

add DatabaseAccount and migrate to MariaDBAccount #398

merged 1 commit into from
Mar 11, 2024

Conversation

zzzeek
Copy link
Contributor

@zzzeek zzzeek commented Feb 21, 2024 •
edited
Loading

This moves ironic to fully use MariaDBAccount based on the dev work being done for mariadb-operator:

https://github.com/openstack-k8s-operators/mariadb-operator/pull/184/files

Lead Jira: OSPRH-4095

  1. controller calls EnsureMariaDBAccount up front to make sure MariaDBAccount is present
  2. error code from EnsureMariaDBAccount is handled, Conditions are amended when error is returned
  3. controller calls NewDatabaseForAccount instead of NewDatabase
  4. GetAccountAndSecret is used to retrieve account /secret to populate template
  5. GetDatabaseByName() , normally used for delete finalizers, replaced with GetDatabaseByNameAndAccount
  6. CreateOrPatchAll() used to patch the Database, replacing CreateOrPatchDB / CreateOrPatchDBByName
  7. controller calls DeleteUnusedMariaDBAccountFinalizers when launched pods are definitely running on a new MariaDBAccount, returns error code if present
  8. PasswordSelectors that refer to database are removed
  9. all databaseUser replaced with databaseAccount inside of all XYZ_types.go added brand new databaseAccount fields
  10. all databaseUser replaced with databaseAccount inside of all kuttl/*.yaml
  11. all default databaseUser names become databaseAccount, replacing underscores with dashes inside of all XYZ_types.go
  12. all default databaseUser names become databaseAccount, replacing underscores with dashes inside of all kuttl/*.yaml
  13. MariaDBAccountSuiteTests are used in controller ginkgo tests if it has them
  14. Use configsecrets for database URLs; remove from job hash
  15. 184 is merged and replaces from go.mod are removed

@openshift-ci openshift-ci bot requested review from hjensas and lewisdenny February 21, 2024 18:29
@zzzeek zzzeek force-pushed the integrate_oo_accounts branch 3 times, most recently from 9beb738 to 46f3d82 Compare February 21, 2024 20:37
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a6d49f4b1c104e38b6946530e6219e66

❌ openstack-k8s-operators-content-provider FAILURE in 9m 15s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@zzzeek
Copy link
Contributor Author

zzzeek commented Feb 21, 2024

recheck

@zzzeek zzzeek force-pushed the integrate_oo_accounts branch from 46f3d82 to e932d4b Compare February 21, 2024 22:49
@zzzeek
Copy link
Contributor Author

zzzeek commented Feb 21, 2024

/retest

@zzzeek zzzeek marked this pull request as draft February 22, 2024 00:26
@zzzeek zzzeek marked this pull request as ready for review February 22, 2024 00:26
@zzzeek zzzeek force-pushed the integrate_oo_accounts branch from e932d4b to 49fb004 Compare February 22, 2024 02:05
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b48a0e88257d41ce9048b279c8270038

❌ openstack-k8s-operators-content-provider FAILURE in 9m 17s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@zzzeek
Copy link
Contributor Author

zzzeek commented Feb 22, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/47718371d06a4c069a17a2785175f6d9

❌ openstack-k8s-operators-content-provider FAILURE in 8m 28s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@zzzeek zzzeek force-pushed the integrate_oo_accounts branch 2 times, most recently from 1b11a74 to d6e6c76 Compare February 22, 2024 16:07
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/229f5921420044c28bdd783682ee5963

❌ openstack-k8s-operators-content-provider FAILURE in 9m 58s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@zzzeek
Copy link
Contributor Author

zzzeek commented Feb 22, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/4c3ca4f38208483a82dbfce40dad73c5

❌ openstack-k8s-operators-content-provider FAILURE in 8m 32s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@zzzeek zzzeek force-pushed the integrate_oo_accounts branch 2 times, most recently from 1cdaad3 to 9ff580d Compare February 22, 2024 19:53
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a7d07ad411324e769f6dba436f33e94b

❌ openstack-k8s-operators-content-provider FAILURE in 8m 03s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@zzzeek
Copy link
Contributor Author

zzzeek commented Feb 22, 2024

recheck

@zzzeek zzzeek force-pushed the integrate_oo_accounts branch from 9ff580d to 2f2e3af Compare February 22, 2024 22:04
@juliakreger juliakreger requested a review from steveb February 29, 2024 17:44
@zzzeek zzzeek force-pushed the integrate_oo_accounts branch from 2f2e3af to 96bd812 Compare March 4, 2024 18:40
@zzzeek
Copy link
Contributor Author

zzzeek commented Mar 6, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/21462470796d411eb7b381a28401bc33

❌ openstack-k8s-operators-content-provider FAILURE in 17m 03s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@zzzeek zzzeek force-pushed the integrate_oo_accounts branch from 292ee5f to 40e840c Compare March 6, 2024 21:44
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/097416213c6446348623a91af749b896

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 03m 27s
❌ podified-multinode-ironic-deployment FAILURE in 39m 47s

@zzzeek
Copy link
Contributor Author

zzzeek commented Mar 7, 2024

/test ironic-operator-build-deploy-kuttl

@zzzeek
Copy link
Contributor Author

zzzeek commented Mar 7, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/099440802ba14ad695ebb80f7d331538

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 02m 04s
❌ podified-multinode-ironic-deployment FAILURE in 39m 55s

@hjensas
Copy link
Contributor

hjensas commented Mar 7, 2024

recheck

@zzzeek
Copy link
Contributor Author

zzzeek commented Mar 8, 2024

@hjensas @stuggi this should be all set after finally passing CI

@zzzeek
Copy link
Contributor Author

zzzeek commented Mar 8, 2024

note this is another "big" one where I moved from configmaps to secrets. tests passing / deployment succeeding is a good sign things are OK

steveb
steveb approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@steveb steveb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zzzeek zzzeek force-pushed the integrate_oo_accounts branch from 40e840c to c69d5ba Compare March 11, 2024 11:39
@openshift-ci openshift-ci bot removed the lgtm label Mar 11, 2024
@zzzeek zzzeek force-pushed the integrate_oo_accounts branch from c69d5ba to dd01188 Compare March 11, 2024 13:04
@zzzeek
Copy link
Contributor Author

zzzeek commented Mar 11, 2024

/retest

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/066a0d37197849cbbdff21ed1e41072e

❌ openstack-k8s-operators-content-provider FAILURE in 8m 53s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@zzzeek zzzeek force-pushed the integrate_oo_accounts branch from dd01188 to 95b3db1 Compare March 11, 2024 14:17
@zzzeek
Copy link
Contributor Author

zzzeek commented Mar 11, 2024

/retest

1 similar comment
@zzzeek
Copy link
Contributor Author

zzzeek commented Mar 11, 2024

/retest

@zzzeek
Copy link
Contributor Author

zzzeek commented Mar 11, 2024

OK it built, ready for approve @steveb @hjensas

steveb
steveb approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@steveb steveb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 11, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: steveb, zzzeek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2f562cb into openstack-k8s-operators:main Mar 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveb steveb steveb approved these changes

@hjensas hjensas Awaiting requested review from hjensas

@lewisdenny lewisdenny Awaiting requested review from lewisdenny

@gibizer gibizer Awaiting requested review from gibizer

Assignees

@steveb steveb

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zzzeek @hjensas @steveb @openshift-merge-robot