[OSPRH-21958] Upgrade to Operator SDK 1.41.1 #646
+1,549
−894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
abays
force-pushed
the
operator_sdk_1.41.1
branch
2 times, most recently
from
d957eeb to
9149bd2
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Contributor
Author
|
recheck |
Contributor
Author
|
/test ironic-operator-build-deploy-kuttl |
1 similar comment
Contributor
Author
|
/test ironic-operator-build-deploy-kuttl |
abays
force-pushed
the
operator_sdk_1.41.1
branch
2 times, most recently
from
34b64db to
a601852
Compare
This commit migrates the ironic-operator from Operator SDK 1.31.0 to 1.41.1, following the new project structure and best practices introduced in the newer SDK version. Major Changes: Project Structure Reorganization: - Moved entry point from root main.go to cmd/main.go - Created internal/ directory structure following operator-sdk 1.41.1 conventions: - internal/controller/ - Contains all controllers (moved from controllers/) - internal/webhook/v1beta1/ - Contains webhook setup functions - Updated all import paths and package declarations accordingly Build System Updates: - Updated Makefile to use operator-sdk v1.41.1 - Updated CONTROLLER_TOOLS_VERSION to v0.16.4 for compatibility - Updated Dockerfile to use new main.go location - Updated build and run targets for new project structure Configuration Enhancements: - Enhanced certmanager configuration with separate certificates for metrics and webhooks - Added network-policy configuration for secure traffic control: - allow-metrics-traffic.yaml - Restricts metrics access to openstack namespace - allow-webhook-traffic.yaml - Allows webhook traffic from all namespaces - Enhanced RBAC configuration: - Added metrics_auth_role.yaml for TokenReview and SubjectAccessReview permissions - Added ironic_admin_role.yaml for full Ironic resource management - Updated existing roles with proper operator-sdk 1.41.1 labels and metadata - Updated manager configuration: - Added cert_metrics_manager_patch.yaml for TLS certificate mounting - Added manager_metrics_patch.yaml with kube-rbac-proxy sidecar for secure metrics - Enhanced Prometheus monitoring with TLS support via monitor_tls_patch.yaml Controller and Webhook Updates: - Migrated webhook registration to function-based approach: - Created SetupIronicWebhookWithManager() function in internal/webhook/v1beta1/ - Updated cmd/main.go to use new webhook setup pattern - Updated all controller package declarations and imports - Fixed test imports in tests/functional/suite_test.go Dependency Management: - Updated go.mod and go.sum with compatible dependency versions - Resolved go.work version conflicts - Maintained compatibility with existing OpenStack operator ecosystem The upgrade maintains 100% backward compatibility while modernizing the codebase to align with operator-sdk 1.41.1 best practices for security, monitoring, and deployment configurations. All ironic-operator resources continue to function correctly: - Ironic (main resource with webhooks) - IronicAPI - IronicConductor - IronicInspector - IronicNeutronAgent Verified functionality: - Build: PASS - Manifests generation: PASS - Bundle generation: PASS - Unit tests: PASS Co-Authored-By: Claude <[email protected]> Related: https://issues.redhat.com/browse/OSPRH-21958
abays
force-pushed
the
operator_sdk_1.41.1
branch
from
a601852 to
ad84696
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit migrates the ironic-operator from Operator SDK 1.31.0 to 1.41.1, following the new project structure and best practices introduced in the newer SDK version.
Major Changes:
Project Structure Reorganization:
Build System Updates:
Configuration Enhancements:
Controller and Webhook Updates:
Dependency Management:
The upgrade maintains 100% backward compatibility while modernizing the codebase to align with operator-sdk 1.41.1 best practices for security, monitoring, and deployment configurations.
All ironic-operator resources continue to function correctly:
Verified functionality:
Related: https://issues.redhat.com/browse/OSPRH-21958
Co-Authored-By: Claude [email protected]
Depends-On: openstack-k8s-operators/openstack-operator#1683