Simplify and fix name issue with ToCoreVolume #576
Merged
+5
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dprince
force-pushed
the
to_core_volume_fix
branch
from
f9f8290 to
0f8bfb6
Compare
stuggi
reviewed
Oct 29, 2024
| volSource, err := s.VolumeSource.ToCoreVolumeSource() | ||
| coreVolume := &corev1.Volume{ | ||
| Name: s.Name, | ||
| VolumeSource: *volSource, |
There was a problem hiding this comment.
in case of error when *volSource is nil this will hit a nil ptr dereference error. should check for err condition before.
There was a problem hiding this comment.
good call, pushed a fix for that
dprince
force-pushed
the
to_core_volume_fix
branch
from
0f8bfb6 to
fd3b69f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.