Update volumesource to be json inline #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
testing this fix here: openstack-k8s-operators/openstack-operator#1158 |
dprince
force-pushed
the
volume_inline_fix
branch
2 times, most recently
from
0d9a5e1 to
8d52793
Compare
fmount
reviewed
Nov 4, 2024
modules/storage/storage.go
Outdated
| // VolumeSource defines the source of a volume to be mounted | ||
| VolumeSource VolumeSource `json:"volumeSource"` | ||
| VolumeSource VolumeSource `json:",inline" protobuf:"bytes,2,opt,name=volumeSource"` |
There was a problem hiding this comment.
I think we still need a small change of L103. As per my tests (in manila-operator) it should be:
VolumeSource `json:",inline" protobuf:"bytes,2,opt,name=volumeSource"``
There was a problem hiding this comment.
Good catch!. Pushed a fix.
dprince
force-pushed
the
volume_inline_fix
branch
from
8d52793 to
d5acfee
Compare
|
Testing was still in progress but early results in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.