[test helper] fix nad test helper to return valid json config #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Schuppert <[email protected]>
olliewalsh
approved these changes
Nov 13, 2024
| @@ -36,7 +36,7 @@ func (tc *TestHelper) CreateNetworkAttachmentDefinition(name types.NamespacedNam | |||
| Namespace: name.Namespace, | |||
| }, | |||
| Spec: networkv1.NetworkAttachmentDefinitionSpec{ | |||
| Config: "", | |||
| Config: `{}`, | |||
There was a problem hiding this comment.
empty string isn't a valid json object I assume?
There was a problem hiding this comment.
yes, unmarshal it as part of https://github.com/openstack-k8s-operators/lib-common/blob/main/modules/common/networkattachment/networkattachment.go#L158 would fail with:
2024-11-13T15:33:24+01:00 ERROR Reconciler error {"controller": "cinder", "controllerGroup": "cinder.openstack.org", "controllerKind": "Cinder", "Cind
er": {"name":"cinder-6af4b","namespace":"4eed3b56-5a11-486a-a472-00a9499f9289"}, "namespace": "4eed3b56-5a11-486a-a472-00a9499f9289", "name": "cinder-6af4b", "reconcileID": "526ff203-812e-4e6e-9608-7f1a28b8084b", "error": "failed create network annotation from [internalapi]: failed to unmarshal JSON data: unexpected end of JSON input"}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/OSPRH-8680