DNM - Cleanup kuttl tests #386
Open
+5
−1,988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test manila-operator-build-deploy-kuttl |
1 similar comment
|
/test manila-operator-build-deploy-kuttl |
|
This is interesting, from the existing events log we can see: It succeed at some point, but it's not clear why db-sync fails at the beginning (this seem a consistent behavior). |
fmount
force-pushed
the
kuttl-cleanup
branch
2 times, most recently
from
2f432e3 to
73f4f48
Compare
|
The bad news is that I'm not able to reproduce the same error locally, where everything passes as expected: |
fmount
force-pushed
the
kuttl-cleanup
branch
4 times, most recently
from
47f4236 to
a96c64b
Compare
The existing kuttl tests match the whole Manila CR spec, including parameters that are not meaninful to make the test pass or not. This patch removes a lot of fields that are not required in the main assertion. For example, matching the status is often sufficient to assert the status of the reconciliation, conditions, and to check if a resource has been properly deployed. Signed-off-by: Francesco Pantano <[email protected]>
|
/test manila-operator-build-deploy-kuttl |
Signed-off-by: Francesco Pantano <[email protected]>
|
@fmount: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I think now I have a more clear idea of what's going on. Clearly, after a few minutes (when we reach and we get no logs. |
|
Looks like the problem is in the image used by the job: and this explains why we had working tests until 3 days ago. In my local environment I get by default an image based on the working tag, and that's why I wasn't able to reproduce it. |
|
After doing a few more tests, we can see that after downgrading |
|
Kuttl blocked by this bug: https://issues.redhat.com/browse/RHEL-78362 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
kuttltests match the wholeManila CRspec (including sub resources spec), including parameters that are not meaningful to make the test pass or not.This patch removes a lot of fields that are not required in the main assertion. For example, matching the status is often sufficient to assert the status of the reconciliation, conditions, and to check if a resource has been properly deployed; images are not tested via kuttl, and we have jobs testing both the container image injection and a minor update with custom images.
This is the first step to reorganize kuttl tests into independent test suites.
I might need to hold-the-node for test purposes