-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: multiple related images with the same image ref #612
Fix: multiple related images with the same image ref #612
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gibizer, mrkisaolamb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/fd30a90c5b8c4ec48edde6f5b832d914 ✔️ nova-operator-content-provider SUCCESS in 2h 11m 27s |
5fef42f
to
79ed486
Compare
New changes are detected. LGTM label has been removed. |
79ed486
to
261e532
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/ee0a43cfa1814da888d7d648cb0a144f ✔️ nova-operator-content-provider SUCCESS in 1h 01m 41s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/22ddc043b63748eeb63e36a49d72f2d7 ❌ nova-operator-content-provider FAILURE in 16m 03s |
recheck |
I'm probably blind but I don't see the actual error in the content provider |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/3d26a92e6ac64498b14bf48f4200eb56 ❌ nova-operator-content-provider FAILURE in 13m 41s |
.zuul.yaml
Outdated
# TODO(samborka): remove this once we have a running barbican | ||
- barbican_tempest_plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please move this either above L136 or below one of our sections. Each section is separated with a dedented comment describing the reason why the set of tests are disabled. Now you added this in the middle of the cinder section.
- this skip alone won't be enough. We need to skip the other test cases that started to run due to barbican is now enabled in the deployment:
tempest.scenario.test_encrypted_cinder_volumes.TestEncryptedCinderVolumes
261e532
to
27614c0
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/27f1d06989944aca95c3b92d113a30ac ❌ nova-operator-content-provider FAILURE in 13m 14s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/bd681e20c61d45379c985639da7d06db ❌ nova-operator-content-provider FAILURE in 15m 18s |
Force merging this as we suspect that the image build failure blocking this is goes away with this fix. |
No description provided.